Re: [PATCH 04/13] btrfs: factor out RAID1 block mapping

Christoph Hellwig
2023-12-13T08:52:12Z

On Tue, Dec 12, 2023 at 04:38:02AM -0800, Johannes Thumshirn wrote:
> Now that we have a container for the I/O geometry that has all the needed
> information for the block mappings of RAID1, factor out a helper calculating
> this information.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> ---
> fs/btrfs/volumes.c | 31 +++++++++++++++++++++----------
> 1 file changed, 21 insertions(+), 10 deletions(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index a5d85a77da25..f6f1e783b3c1 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -6372,6 +6372,25 @@ static void map_blocks_for_raid0(struct btrfs_chunk_map *map,
> io_geom->mirror_num = 1;
> }
>
> +static void map_blocks_for_raid1(struct btrfs_fs_info *fs_info,
> + struct btrfs_chunk_map *map,
> + enum btrfs_map_op op,
> + struct btrfs_io_geometry *io_geom, int replace)

replace looks like a bool to me. Also elsewhere in the code it is
called dev_replace_is_ongoing. Even if that name is a little clumsy
it's nice to not switch forth and back between names in a call chain.