linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
	linux-pm <linux-pm@vger.kernel.org>,
	linux-kernel@vger.kernel.org, Chris Mason <clm@fb.com>,
	Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	linux-btrfs@vger.kernel.org, Russ Weight <russ.weight@linux.dev>,
	Danilo Krummrich <dakr@redhat.com>
Subject: Re: Root filesystem read access for firmware load during hibernation image writing
Date: Fri, 11 Oct 2024 16:44:04 -0700	[thread overview]
Message-ID: <Zwm4RMDAfMH-ussN@bombadil.infradead.org> (raw)
In-Reply-To: <20241011233953.GJ21877@frogsfrogsfrogs>

On Fri, Oct 11, 2024 at 04:39:53PM -0700, Darrick J. Wong wrote:
> On Fri, Oct 11, 2024 at 04:11:49PM -0700, Luis Chamberlain wrote:
> 
> Reads are generally supposed to succeed on a suspended system but if the
> read causes a write (e.g. atime update) they can block just like a write
> would.  So in the end you probably have to cache the firmware blobs in a
> tmpfs or something like that.

The fw cache stuff caches is it in memory to avoid these races on resume.

> > So.. we just now gotta respin the latest effort. I had stopped because
> > I know Darrick had some changes which he needed to get in sooner but
> 
> Do you remember what changes those were?  I don't. :(

Yeah I have a random tree somewhere lemme see...

https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20230507-fs-freeze

Fortunately most of it is coccinelle smpl so should be easy to rebase.

  Luis

  reply	other threads:[~2024-10-11 23:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28 19:08 Root filesystem read access for firmware load during hibernation image writing Maciej S. Szmigiero
2024-10-05 13:16 ` Maciej S. Szmigiero
2024-10-11 23:11   ` Luis Chamberlain
2024-10-11 23:39     ` Darrick J. Wong
2024-10-11 23:44       ` Luis Chamberlain [this message]
2024-10-05 17:40 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zwm4RMDAfMH-ussN@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=clm@fb.com \
    --cc=dakr@redhat.com \
    --cc=djwong@kernel.org \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=len.brown@intel.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    --cc=russ.weight@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).