From: Dominique Martinet <dominique.martinet@atmark-techno.com>
To: David Sterba <dsterba@suse.cz>
Cc: linux-btrfs@vger.kernel.org, wqu@suse.com
Subject: Re: [PATCH] btrfs-progs: device-utils: include libgen.h for musl
Date: Thu, 21 Nov 2024 07:23:09 +0900 [thread overview]
Message-ID: <Zz5hTSPUCurvevGd@atmark-techno.com> (raw)
In-Reply-To: <20241120200505.GX31418@twin.jikos.cz>
David Sterba wrote on Wed, Nov 20, 2024 at 09:05:06PM +0100:
> > +#include <libgen.h>
>
> Please don't add libgen.h anywhere, this causes problems so the solution
> we ended up was a one place with correct includes, which is
> path-utils.c. Then path_basename() needs to be used instead of plain
> basename() calls.
Argh, sorry.
I'm not sure what I built the other day that produced this warning,
master has been fixed for a while.. Please forget about this patch.
> For reference:
>
> - issue 778
> - commit 884a609a77a6ddb7f0e0ba8789e0f0fc0e899dab
> - commit d95a14949d80c7c7d6bb081d812ddcd39ba4b24d
Thanks for the references, I'll go drop the patch from alpine so others
don't make the same mistake.
--
Dominique
prev parent reply other threads:[~2024-11-20 22:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 1:43 [PATCH] btrfs-progs: device-utils: include libgen.h for musl Dominique Martinet
2024-11-19 4:31 ` Qu Wenruo
2024-11-20 20:05 ` David Sterba
2024-11-20 22:23 ` Dominique Martinet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zz5hTSPUCurvevGd@atmark-techno.com \
--to=dominique.martinet@atmark-techno.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox