public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dominique Martinet <asmadeus@codewreck.org>
To: "Marek Behún" <kabel@kernel.org>, "Qu Wenruo" <wqu@suse.com>,
	"Tom Rini" <trini@konsulko.com>
Cc: Dominique Martinet <dominique.martinet@atmark-techno.com>,
	linux-btrfs@vger.kernel.org, u-boot@lists.denx.de
Subject: Re: [u-boot PATCH] fs: btrfs: hide 'Cannot lookup file' errors on 'load'
Date: Wed, 13 Nov 2024 14:58:42 +0900	[thread overview]
Message-ID: <ZzRAEgQYS46yM7Ct@codewreck.org> (raw)

Dominique Martinet wrote on Wed, Nov 06, 2024 at 09:56:42AM +0900:
> Running commands such as 'load mmc 2:1 $addr $path' when path does not
> exists historically do not print any error on filesystems such as ext4
> or fat.
> Changing the root filesystem to btrfs would make existing boot script
> print 'Cannot lookup file xxx' errors, confusing customers wondering if
> there is a problem when the mmc load command was used in a if (for
> example to load boot.scr conditionally)

Ugh, sorry, I was a bit quick on checking with an updated u-boot on
this... our tree is *cough* slightly *cough* old and that was the case
at the time, but since somewhere in 2020 there is a warning in fs/fs.c
in case load fails.

That doesn't change the fact that this patch is useful to avoid the
message being printed twice, but I'll need to update my scripts anyway
to use `size` first instead (as a first approximation of `test -e`)

Please let me know if you want me to resend this with an updated commit
message; otherwise I'll let this sleep.

-- 
Dominique

             reply	other threads:[~2024-11-13  5:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-13  5:58 Dominique Martinet [this message]
2024-11-13 14:14 ` [u-boot PATCH] fs: btrfs: hide 'Cannot lookup file' errors on 'load' Tom Rini
  -- strict thread matches above, loose matches on Subject: below --
2024-11-06  1:29 Dominique Martinet
2024-11-06  4:23 ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZzRAEgQYS46yM7Ct@codewreck.org \
    --to=asmadeus@codewreck.org \
    --cc=dominique.martinet@atmark-techno.com \
    --cc=kabel@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox