From: Qu Wenruo <wqu@suse.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] btrfs: merge btrfs_read_dev_one_super() into btrfs_read_disk_super()
Date: Tue, 29 Apr 2025 08:41:50 +0930 [thread overview]
Message-ID: <a171a80c-bce1-4dc3-bb3a-f40fe17917bb@suse.com> (raw)
In-Reply-To: <1cfd4998-e220-43da-b78d-2a7efa3f681e@wdc.com>
在 2025/4/28 23:51, Johannes Thumshirn 写道:
> On 28.04.25 03:16, Qu Wenruo wrote:
>> + ret = btrfs_sb_log_location_bdev(bdev, copy_num, READ, &bytenr);
>> + if (ret == -ENOENT)
>> + return ERR_PTR(-EINVAL);
>> + else if (ret)
>> + return ERR_PTR(ret);
>
> Nit: else after return is superfluous.
>
> Maybe even:
>
> if (ret) {
> if (ret == -ENOENT)
> ret = -EINVAL
> return ERR_PTR(ret);
> }
Sure, I'll modify it at the merge time.
Thanks,
Qu
next prev parent reply other threads:[~2025-04-28 23:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 1:15 [PATCH 0/2] btrfs: merge the two different super block read functions into one Qu Wenruo
2025-04-28 1:15 ` [PATCH 1/2] btrfs: merge btrfs_read_dev_one_super() into btrfs_read_disk_super() Qu Wenruo
2025-04-28 14:21 ` Johannes Thumshirn
2025-04-28 23:11 ` Qu Wenruo [this message]
2025-04-29 7:14 ` David Sterba
2025-04-29 7:22 ` David Sterba
2025-04-29 7:39 ` Qu Wenruo
2025-04-28 1:15 ` [PATCH 2/2] btrfs: get rid of btrfs_read_dev_super() Qu Wenruo
2025-04-29 7:17 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a171a80c-bce1-4dc3-bb3a-f40fe17917bb@suse.com \
--to=wqu@suse.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox