public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 0/4] btrfs: move some features out of experimental
Date: Wed, 4 Mar 2026 14:34:32 +1030	[thread overview]
Message-ID: <a19ad870-a52a-4e26-8ac7-cfabfb4a5e4b@suse.com> (raw)
In-Reply-To: <20260304035752.GH8455@twin.jikos.cz>



在 2026/3/4 14:27, David Sterba 写道:
> On Fri, Feb 27, 2026 at 02:03:42PM +1030, Qu Wenruo wrote:
>> [CHANGELOG]
>> v2:
>> - Move bs < ps && bs != 4K out of experimental
>>    That feature is a pretty small niche though.
>>    The basis is already there from the bs < ps support for a while.
>>
>> - Remove 2K block size support
>>    That is too niche, considering how easy to trigger subpage routine
>>    with the larger data folio support, there is not much need for it.
>>
>> The following features can be moved out of experimental in v7.1:
>>
>> - Large data folios
>>    It's introduced in v6.17, but we still have a bug fix related for it
>>    in v6.19.
>>    If there is no new bug exposed I believe it's time to expose this
>>    feature to end users.
>>
>> - Shutdown and remove_bdev callbacks
>>    It's introduced in v6.19, but there is no major known bug exposed yet.
>>    Furthermore the remove_bdev callback, aka auto-shutdown/degradation
>>    when a device is missing, can affect end users.
>>
>>    Thus we want some feedbacks from early adopters.
>>
>> - Block size smaller than page size but not 4K support
>>    The requirement for 4K block size is purely artificial to reduce our
>>    test load.
>>    But since we're moving towards supporting all block sizes, the
>>    artifical limit can be lifted now.
> 
> Adding all of them at once feels a bit risky. I don't think that it has
> enough exposure and testing because of number of the possible
> combinations.
> 
> The shutdown is orthogonal to the rest so this can be enabled by
> default.

So can I add that shutdown one into for-next branch?

> For the rest the bs/ps is namely an ARM thing with the 64K
> pages,

Thus I'd say it shouldn't affect most end users (if any).

> and large folios is using an internal API in a new way.

That one has been there for testing for a while, and we have exposed 
bugs related to that (on x86_64).
(That's also why I tend to remove 2K block size, since we can reach the 
same result without subpage/2K bs on x86_64)

So it should have been tested by us.
Although I'm fine delaying this to be extra safe, I still prefer this to 
be enabled sooner than later (hopefully 7.2 merge window).

Thanks,
Qu

> Here I'd pick just one and make sure we have it covered by CI. I'm
> setting it up again on github actions but it's going slower than
> expected.


  reply	other threads:[~2026-03-04  4:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27  3:33 [PATCH v2 0/4] btrfs: move some features out of experimental Qu Wenruo
2026-02-27  3:33 ` [PATCH v2 1/4] btrfs: drop 2K block size support Qu Wenruo
2026-03-04  3:48   ` David Sterba
2026-03-04  3:51     ` Qu Wenruo
2026-02-27  3:33 ` [PATCH v2 2/4] btrfs: move shutdown and remove_bdev callbacks out of experimental features Qu Wenruo
2026-02-27  3:33 ` [PATCH v2 3/4] btrfs: move larger data folios " Qu Wenruo
2026-03-10  6:43   ` kernel test robot
2026-03-10  7:03     ` Qu Wenruo
2026-03-10  7:21       ` Oliver Sang
2026-03-10  7:58         ` Qu Wenruo
2026-03-11 13:38           ` Oliver Sang
2026-02-27  3:33 ` [PATCH v2 4/4] btrfs: move block size < page size support " Qu Wenruo
2026-03-04  3:57 ` [PATCH v2 0/4] btrfs: move some features out of experimental David Sterba
2026-03-04  4:04   ` Qu Wenruo [this message]
2026-03-16  8:58     ` David Sterba
2026-03-16  9:16       ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a19ad870-a52a-4e26-8ac7-cfabfb4a5e4b@suse.com \
    --to=wqu@suse.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox