From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>, linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>, Naohiro Aota <naohiro.aota@wdc.com>
Subject: Re: [PATCH] btrfs: zoned: propagate do_zone_finish() error in btrfs_zone_finish_endio()
Date: Wed, 19 Aug 2026 10:34:21 +0200 [thread overview]
Message-ID: <a1e2bc7f-2b37-4dba-9355-616fcaa67de4@wdc.com> (raw)
In-Reply-To: <d3ba712b-9403-4cd4-9c28-c3c6fba59c19@gmx.com>
On 8/19/26 12:44 AM, Qu Wenruo wrote:
>
>
> 在 2026/8/19 08:11, Qu Wenruo 写道:
>>
>>
>> 在 2026/8/18 19:30, Johannes Thumshirn 写道:
>>> btrfs_zone_finish_endio() ignored the return value of do_zone_finish()
>>> and always returned 0, silently dropping a failed zone finish.
>>>
>>> Instead propagate any error from do_zone_finish() as the caller
>>> btrfs_finish_ordered_io() already handles it.
>>>
>>> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
>>
>> Reviewed-by: Qu Wenruo <wqu@suse.com>
>
> BTW, you may still want to check the sashiko review, which exposed an
> pre-existing bug in the error handling path:
>
> https://sashiko.dev/#/patchset/20260818100037.1366563-1-johannes.thumshirn%40wdc.com
Oh thanks, I would've missed this. From a quick glance it looks valid.
I'll take care of it.
prev parent reply other threads:[~2026-08-19 8:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 10:00 [PATCH] btrfs: zoned: propagate do_zone_finish() error in btrfs_zone_finish_endio() Johannes Thumshirn
2026-08-18 22:41 ` Qu Wenruo
2026-08-18 22:44 ` Qu Wenruo
2026-08-19 8:34 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1e2bc7f-2b37-4dba-9355-616fcaa67de4@wdc.com \
--to=johannes.thumshirn@wdc.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox