From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/5] btrfs: tree-checker: Verify block_group_item
Date: Wed, 4 Jul 2018 08:54:17 +0300 [thread overview]
Message-ID: <a2ce3e7c-ef70-123f-426b-6f4c0945e793@suse.com> (raw)
In-Reply-To: <20180703091009.16399-2-wqu@suse.com>
On 3.07.2018 12:10, Qu Wenruo wrote:
> A crafted image with invalid block group items could make free space cache
> code to cause panic.
>
> We could early detect such invalid block group item by checking:
> 1) Item size
> Fixed value.
> 2) Block group size (key.offset)
> We have a up limit on block group item (10G)
> 3) Chunk objectid
> Fixed value.
> 4) Type
> Only 4 valid type values, DATA, METADATA, SYSTEM and DATA|METADATA.
> No more than 1 bit set for profile type.
> 5) Used space
> No more than block group size.
>
> This should allow btrfs to detect and refuse to mount the crafted image.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=199849
> Reported-by: Xu Wen <wen.xu@gatech.edu>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
next prev parent reply other threads:[~2018-07-04 5:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 9:10 [PATCH 0/5] Enhancement for block group/chunk verification Qu Wenruo
2018-07-03 9:10 ` [PATCH 1/5] btrfs: tree-checker: Verify block_group_item Qu Wenruo
2018-07-04 2:20 ` Gu, Jinxiang
2018-07-04 5:54 ` Nikolay Borisov [this message]
2018-07-04 7:37 ` Gu, Jinxiang
2018-07-03 9:10 ` [PATCH 2/5] btrfs: tree-checker: Detect invalid empty essential tree Qu Wenruo
2018-07-04 3:42 ` Gu, Jinxiang
2018-07-04 5:56 ` Nikolay Borisov
2018-07-04 7:37 ` Gu, Jinxiang
2018-07-03 9:10 ` [PATCH 3/5] btrfs: relocation: Only remove reloc rb_trees if reloc control has been initialized Qu Wenruo
2018-07-04 5:23 ` Gu, Jinxiang
2018-07-04 7:37 ` Gu, Jinxiang
2018-07-03 9:10 ` [PATCH 4/5] btrfs: Check each block group has corresponding chunk at mount time Qu Wenruo
2018-07-04 5:45 ` Gu, Jinxiang
2018-07-05 23:41 ` Qu Wenruo
2018-07-04 6:02 ` Nikolay Borisov
2018-07-03 9:10 ` [PATCH 5/5] btrfs: Verify every chunk has corresponding block group " Qu Wenruo
2018-07-04 6:09 ` Gu, Jinxiang
2018-07-04 7:08 ` Nikolay Borisov
2018-07-04 9:46 ` Qu Wenruo
2018-07-05 23:49 ` Qu Wenruo
2018-07-05 15:18 ` David Sterba
2018-07-05 23:44 ` Qu Wenruo
2018-07-16 13:16 ` David Sterba
2018-07-16 13:57 ` Qu Wenruo
2018-07-17 12:33 ` David Sterba
2018-07-17 13:32 ` Qu Wenruo
2018-07-19 14:22 ` David Sterba
2018-07-04 13:36 ` [PATCH 0/5] Enhancement for block group/chunk verification David Sterba
2018-07-05 1:36 ` Qu Wenruo
2018-07-05 15:18 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2ce3e7c-ef70-123f-426b-6f4c0945e793@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).