From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Cc: jamespharvey20@gmail.com
Subject: Re: [PATCH 1/4] btrfs: compression: Add linux/sizes.h for compression.h
Date: Thu, 17 May 2018 10:49:00 +0300 [thread overview]
Message-ID: <a32450c0-9aa7-a568-e39a-250fdf8a1316@suse.com> (raw)
In-Reply-To: <20180517062753.25973-2-wqu@suse.com>
On 17.05.2018 09:27, Qu Wenruo wrote:
> Since compression.h is using SZ_* macros, and if some user only includes
> compression.h without linux/sizes.h, it will cause compile error.
>
> One example is lzo.c, if it uses BTRFS_MAX_COMPRESSED, it would cause
> compile error.
>
> Fix it by adding linux/sizes.h in compression.h
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/compression.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/btrfs/compression.h b/fs/btrfs/compression.h
> index cc605f7b23fb..317703d9b073 100644
> --- a/fs/btrfs/compression.h
> +++ b/fs/btrfs/compression.h
> @@ -6,6 +6,7 @@
> #ifndef BTRFS_COMPRESSION_H
> #define BTRFS_COMPRESSION_H
>
> +#include <linux/sizes.h>
> /*
> * We want to make sure that amount of RAM required to uncompress an extent is
> * reasonable, so we limit the total size in ram of a compressed extent to
>
next prev parent reply other threads:[~2018-05-17 7:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 6:27 [PATCH 0/4] btrfs: lzo: Harden decompression callers to avoid Qu Wenruo
2018-05-17 6:27 ` [PATCH 1/4] btrfs: compression: Add linux/sizes.h for compression.h Qu Wenruo
2018-05-17 7:49 ` Nikolay Borisov [this message]
2018-05-17 6:27 ` [PATCH 2/4] btrfs: lzo: Add comment about the how btrfs records its lzo compressed data Qu Wenruo
2018-05-17 7:48 ` Nikolay Borisov
2018-05-17 8:04 ` Qu Wenruo
2018-05-17 6:27 ` [PATCH 3/4] btrfs: lzo: Add header length check to avoid slab out of bounds access Qu Wenruo
2018-05-17 8:14 ` Nikolay Borisov
2018-05-17 8:19 ` Qu Wenruo
2018-05-17 9:05 ` Qu Wenruo
2018-05-22 14:14 ` David Sterba
2018-05-17 6:27 ` [PATCH 4/4] btrfs: lzo: Hardern inline lzo compressed extent decompression Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a32450c0-9aa7-a568-e39a-250fdf8a1316@suse.com \
--to=nborisov@suse.com \
--cc=jamespharvey20@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox