Re: [PATCH v2 6/8] btrfs: verify superblock checksum during scan

[Anand Jain <anand.jain@oracle.com>]

On 03/28/2018 03:21 PM, Nikolay Borisov wrote:
> 
> 
> On 28.03.2018 02:39, Anand Jain wrote:
>> During the scan context, we aren't verifying the superblock-
>> checksum when read.
>> This patch fixes it by adding the checksum verification function
>> btrfs_check_super_csum() in the function btrfs_read_disk_super().
>> And makes device scan to error fail if the primary superblock csum
>> is wrong, whereas if the copy-superblock csum is wrong it will just
>> just report mismatch and continue mount/scan as usual. When the
> 
> Where in this patch do you deal with the secondary sb.


> btrfs_read_disk_super verifies only the primary sb which corresponds to
> the first part of the sentence. But I'm confused about the second?

  btrfs_read_disk_super() actaully reads and csum verifies the copy_num 
as provided.

         bytenr = btrfs_sb_offset(copy_num);

> I also think that 4/8 should be merged into this one.

  Right. I can do that.

Thanks, Anand