From: Nikolay Borisov <nborisov@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Refactor error handling in btrfs_zero_range
Date: Mon, 31 May 2021 10:42:16 +0300 [thread overview]
Message-ID: <a43a205f-4735-9b3c-40a6-6bcb067d544a@suse.com> (raw)
In-Reply-To: <20210225125828.1601531-1-nborisov@suse.com>
On 25.02.21 г. 14:58, Nikolay Borisov wrote:
> The major complexity when it comes to error handling in btrfs_zero_range
> stems from the code executed under the 'reserve_space' label. Rather
> than it having an effect on the whole of btrfs_zero_range refactor it
> so that error handling specific to the functions called in this branch
> is contained only within the branch itself. This obviates the need for
> having the 'space_reserved' local flag since btrfs_free_reserved_data_space
> is called from the 2 error branches it's needed. Furthermore, this
> rids the code from the out label and enables converting most 'goto out'
> statements to simiple 'return ret' making the function easier to read.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Ping
next prev parent reply other threads:[~2021-05-31 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 12:58 [PATCH] btrfs: Refactor error handling in btrfs_zero_range Nikolay Borisov
2021-05-31 7:42 ` Nikolay Borisov [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-03-02 10:45 Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a43a205f-4735-9b3c-40a6-6bcb067d544a@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).