Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: baomingtong001@208suo.com
To: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] btrfs: make unpin_extent_cache return void
Date: Wed, 14 Jun 2023 15:29:30 +0800	[thread overview]
Message-ID: <a478eebcb05b6eebc6bab8996641c2ed@208suo.com> (raw)
In-Reply-To: <20230614072710.34392-1-luojianhong@cdjrlc.com>

The return value of unpin_extent_cache is always 0,
and its caller does not check its return value.

Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
---
  fs/btrfs/extent_map.c | 3 +--
  fs/btrfs/extent_map.h | 2 +-
  2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c
index f3e9aaeb9956..845994b47998 100644
--- a/fs/btrfs/extent_map.c
+++ b/fs/btrfs/extent_map.c
@@ -292,7 +292,7 @@ static void try_merge_map(struct extent_map_tree 
*tree, struct extent_map *em)
   * to the generation that actually added the file item to the inode so 
we know
   * we need to sync this extent when we call fsync().
   */
-int unpin_extent_cache(struct extent_map_tree *tree, u64 start, u64 
len,
+void unpin_extent_cache(struct extent_map_tree *tree, u64 start, u64 
len,
                 u64 gen)
  {
      struct extent_map *em;
@@ -326,7 +326,6 @@ int unpin_extent_cache(struct extent_map_tree *tree, 
u64 start, u64 len,
      free_extent_map(em);
  out:
      write_unlock(&tree->lock);
-    return 0;

  }

diff --git a/fs/btrfs/extent_map.h b/fs/btrfs/extent_map.h
index 35d27c756e08..486a8ea798c7 100644
--- a/fs/btrfs/extent_map.h
+++ b/fs/btrfs/extent_map.h
@@ -97,7 +97,7 @@ struct extent_map *alloc_extent_map(void);
  void free_extent_map(struct extent_map *em);
  int __init extent_map_init(void);
  void __cold extent_map_exit(void);
-int unpin_extent_cache(struct extent_map_tree *tree, u64 start, u64 
len, u64 gen);
+void unpin_extent_cache(struct extent_map_tree *tree, u64 start, u64 
len, u64 gen);
  void clear_em_logging(struct extent_map_tree *tree, struct extent_map 
*em);
  struct extent_map *search_extent_mapping(struct extent_map_tree *tree,
                       u64 start, u64 len);

       reply	other threads:[~2023-06-14  7:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230614072710.34392-1-luojianhong@cdjrlc.com>
2023-06-14  7:29 ` baomingtong001 [this message]
2023-06-14  7:35   ` [PATCH] btrfs: make unpin_extent_cache return void Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a478eebcb05b6eebc6bab8996641c2ed@208suo.com \
    --to=baomingtong001@208suo.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox