From: Chris Mason <clm@fb.com>
To: "Austin S. Hemmelgarn" <ahferroin7@gmail.com>, <dsterba@suse.cz>,
Hans van Kranenburg <hans.van.kranenburg@mendix.com>,
<linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: Do not use data_alloc_cluster in ssd mode
Date: Mon, 24 Jul 2017 15:18:31 -0400 [thread overview]
Message-ID: <a510b7cf-f8c3-ceb7-6a04-dfc21ea495b6@fb.com> (raw)
In-Reply-To: <779fdedf-1318-bf2d-414d-693168d994d6@gmail.com>
On 07/24/2017 03:06 PM, Austin S. Hemmelgarn wrote:
> On 2017-07-24 14:53, Chris Mason wrote:
>> On 07/24/2017 02:41 PM, David Sterba wrote:
>>>
>>> would it be ok for you to keep ssd_working as before?
>>>
>>> I'd really like to get this patch merged soon because "do not use ssd
>>> mode for ssd" has started to be the recommended workaround. Once this
>>> sticks, we won't need to have any ssd mode anymore ...
>>
>> Works for me. I do want to make sure that commits in this area
>> include the workload they were targeting, how they were measured and
>> what impacts they had. That way when we go back to try and change
>> this again we'll understand what profiles we want to preserve.
> Just thinking long term here, but might it make sense to (eventually)
> allow the user to tune how big a chunk of space to look for? I know
> that ext* have options to do this kind of thing, and I think XFS does
> too (but they do it at filesystem creation time), and I do know people
> who make use of those to make sure things are working at their absolute
> best.
Agreed, we have space in the on-disk format to record those preferences,
but we haven't done it in the past.
-chris
next prev parent reply other threads:[~2017-07-24 19:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 11:47 [PATCH] Btrfs: Do not use data_alloc_cluster in ssd mode Hans van Kranenburg
2017-07-21 14:49 ` Adam Borowski
2017-07-21 15:16 ` Hans van Kranenburg
2017-07-21 15:50 ` Austin S. Hemmelgarn
2017-07-21 23:21 ` Hans van Kranenburg
2017-07-24 11:23 ` Austin S. Hemmelgarn
2017-07-24 14:25 ` David Sterba
2017-07-24 17:22 ` Hans van Kranenburg
2017-07-24 17:52 ` David Sterba
2017-07-24 17:56 ` Hans van Kranenburg
2017-07-24 18:01 ` Chris Mason
2017-07-24 18:41 ` David Sterba
2017-07-24 18:53 ` Chris Mason
2017-07-24 19:06 ` Austin S. Hemmelgarn
2017-07-24 19:18 ` Chris Mason [this message]
2017-07-24 22:42 ` Hans van Kranenburg
2017-07-26 13:27 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a510b7cf-f8c3-ceb7-6a04-dfc21ea495b6@fb.com \
--to=clm@fb.com \
--cc=ahferroin7@gmail.com \
--cc=dsterba@suse.cz \
--cc=hans.van.kranenburg@mendix.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).