From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7656DCA9EAD for ; Sun, 20 Oct 2019 14:25:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54C4721929 for ; Sun, 20 Oct 2019 14:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726474AbfJTOYv (ORCPT ); Sun, 20 Oct 2019 10:24:51 -0400 Received: from mailfilter06-out31.webhostingserver.nl ([141.138.169.48]:59698 "EHLO mailfilter06-out31.webhostingserver.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbfJTOYv (ORCPT ); Sun, 20 Oct 2019 10:24:51 -0400 X-Halon-ID: 5d5c3aae-f345-11e9-9223-001a4a4cb958 Received: from s198.webhostingserver.nl (unknown [195.211.72.171]) by mailfilter06.webhostingserver.nl (Halon) with ESMTPSA id 5d5c3aae-f345-11e9-9223-001a4a4cb958; Sun, 20 Oct 2019 16:24:45 +0200 (CEST) Received: from cust-178-250-146-69.breedbanddelft.nl ([178.250.146.69] helo=[10.8.0.10]) by s198.webhostingserver.nl with esmtpa (Exim 4.92.3) (envelope-from ) id 1iMC8T-00AWvR-Gc; Sun, 20 Oct 2019 16:24:45 +0200 Subject: Re: [PATCH 0/3] btrfs-progs: Add check and repair for invalid inode generation To: Qu Wenruo , Qu WenRuo , "linux-btrfs@vger.kernel.org" References: <20190924081120.6283-1-wqu@suse.com> <36d45e31-f125-4b21-a68e-428f807180f7@gmail.com> <796be1b6-1f1d-7946-e53e-9b85610c7c65@gmail.com> <5315fc1e-f0e6-68ca-8938-33bc0dbce07d@gmx.com> <218ddabb-d419-31cd-f092-59f8ffb1a5b4@gmail.com> <6ec4c90c-d276-c03d-9315-f808f21b3769@gmx.com> From: Ferry Toth Message-ID: Date: Sun, 20 Oct 2019 16:24:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <6ec4c90c-d276-c03d-9315-f808f21b3769@gmx.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SendingUser: hidden X-SendingServer: hidden X-Antivirus-Scanner: Clean mail though you should still use an Antivirus X-Authenticated-Id: hidden X-SendingUser: hidden X-SendingServer: hidden Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org Op 20-10-2019 om 16:11 schreef Qu Wenruo: > > > On 2019/10/20 下午9:29, Ferry Toth wrote: >> Op 20-10-2019 om 15:15 schreef Qu WenRuo: >>> >>> >>> On 2019/10/20 下午9:04, Ferry Toth wrote: >>>> Op 20-10-2019 om 02:51 schreef Qu Wenruo: >>>>> >>>>> >>>>> On 2019/10/20 上午8:26, Qu Wenruo wrote: >>>>>> >>>>>> >>>>>> On 2019/10/20 上午12:24, Ferry Toth wrote: >>>>>>> Hi, >>>>>>> >>>>>>> Op 19-10-2019 om 01:50 schreef Qu WenRuo: >>>>>>>> >>>>>>>> >>>>>>>> On 2019/10/19 上午4:32, Ferry Toth wrote: >>>>>>>>> Op 24-09-2019 om 10:11 schreef Qu Wenruo: >>>>>>>>>> We have at least two user reports about bad inode generation makes >>>>>>>>>> kernel reject the fs. >>>>>>>>> >>>>>>>>> May I add my report? I just upgraded Ubuntu from 19.04 -> 19.10 so >>>>>>>>> kernel went from 5.0 -> 5.3 (but I was using 4.15 too). >>>>>>>>> >>>>>>>>> Booting 5.3 leaves me in initramfs as I have /boot on @boot and / >>>>>>>>> on /@ >>>>>>>>> >>>>>>>>> In initramfs I can try to mount but get something like >>>>>>>>> btrfs critical corrupt leaf invalid inode generation open_ctree >>>>>>>>> failed >>>>>>>>> >>>>>>>>> Booting old kernel works just as before, no errors. >>>>>>>>> >>>>>>>>>> According to the creation time, the inode is created by some 2014 >>>>>>>>>> kernel. >>>>>>>>> >>>>>>>>> How do I get the creation time? >>>>>>>> >>>>>>>> # btrfs ins dump-tree -b >>>>>>> device> >>>>>>> >>>>>>> I just went back to the office to reboot to 5.3 and check the >>>>>>> creation >>>>>>> times and found they were 2013 - 2014. >>>>>>> >>>>>>>>> >>>>>>>>>> And the generation member of INODE_ITEM is not updated (unlike the >>>>>>>>>> transid member) so the error persists until latest tree-checker >>>>>>>>>> detects. >>>>>>>>>> >>>>>>>>>> Even the situation can be fixed by reverting back to older kernel >>>>>>>>>> and >>>>>>>>>> copying the offending dir/file to another inode and delete the >>>>>>>>>> offending >>>>>>>>>> one, it still should be done by btrfs-progs. >>>>>>>>>> >>>>>>>>> How to find the offending dir/file from the command line manually? >>>>>>>> >>>>>>>> # find -inum >>>>>>> >>>>>>> This works, thanks. >>>>>>> >>>>>>> But appears unpractical. After fix 2 files and reboot, I found 4 >>>>>>> more, >>>>>>> then 16, then I gave up. >>>>> >>>>> Another solution is use "find" to locate the files with creation time >>>>> before 2015, and copy them to a new file, then replace the old file >>>>> with >>>>> the new file. >>>> >>>> Hmm. But how do I "find" by creation time (otime)? Do you have a >>>> suggestion for this? >>> >>> $ touch -t 201501010000 /tmp/sample >>> $ find -not -cnewer /tmp/sample >> >> AFAIK this compares file modified date with status changed date. So, no >> search for creation date. >> >> And stat /tmp/sample (sorry dutch lang output): >> >> ferry@ferry-quad:~$ stat /tmp/sample >>   Bestand: /tmp/sample >>   Grootte: 0            Blokken: 0            IO-blok: 4096   leeg >> normaal bestand >> Apparaat: 1bh/27d   Inode: 62005381     Koppelingen: 1 >> Toegang: (0664/-rw-rw-r--)   UID: ( 1001/   ferry)   GID: ( 1001/   ferry) >> Toegang:   2015-01-01 00:00:00.000000000 +0100 >> Gewijzigd: 2015-01-01 00:00:00.000000000 +0100 >> Veranderd: 2019-10-20 15:20:50.366163766 +0200 >> Ontstaan:  - > > My bad, always got confused by o/a/c/mtime, as c really looks like *c* > reation, so I always got confused between ctime and otime. > > Then considering not all fs supports otime, find doesn't support that. > I guess it's only possible by other tools.... New stat will support it, but not in Ubuntu 19.10. We did find this: https://github.com/torvalds/linux/blob/master/samples/vfs/test-statx.c and are trying to work out a script that will gzip all files with creation < 2015. Then we can unzip again and overwrite. > BTW, did you find any patterns in those existing offending inodes? > I guess it would be faster than finding a tool supporting otime search. I didn't see any logic. A mix of logs, cached files, journal files etc. + a .kde directory in the / > Thanks, > Qu > >> >> >>> If you want, you can add -exec to that find, but I'd only add that after >>> confirming the execution load is verified. >>> >>> Thanks, >>> Qu >>> >>>> >>>>> It would be much safer than btrfs check --repair. >>>>> >>>>> Thanks, >>>>> Qu >>>>> >>>>> >>>>>>> >>>>>>>> Thanks, >>>>>>>> Qu >>>>>>>> >>>>>>>>> >>>>>>>>>> This patchset adds such check and repair ability to btrfs-check, >>>>>>>>>> with a >>>>>>>>>> simple test image. >>>>>>>>>> >>>>>>>>>> Qu Wenruo (3): >>>>>>>>>>       btrfs-progs: check/lowmem: Add check and repair for invalid >>>>>>>>>> inode >>>>>>>>>>         generation >>>>>>>>>>       btrfs-progs: check/original: Add check and repair for >>>>>>>>>> invalid inode >>>>>>>>>>         generation >>>>>>>>>>       btrfs-progs: fsck-tests: Add test image for invalid inode >>>>>>>>>> generation >>>>>>>>>>         repair >>>>>>>>>> >>>>>>>>>>      check/main.c                                  |  50 >>>>>>>>>> +++++++++++- >>>>>>>>>>      check/mode-lowmem.c                           |  76 >>>>>>>>>> ++++++++++++++++++ >>>>>>>>>>      check/mode-original.h                         |   1 + >>>>>>>>>>      .../.lowmem_repairable                        |   0 >>>>>>>>>>      .../bad_inode_geneartion.img.xz               | Bin 0 -> 2012 >>>>>>>>>> bytes >>>>>>>>>>      5 files changed, 126 insertions(+), 1 deletion(-) >>>>>>>>>>      create mode 100644 >>>>>>>>>> tests/fsck-tests/043-bad-inode-generation/.lowmem_repairable >>>>>>>>>>      create mode 100644 >>>>>>>>>> tests/fsck-tests/043-bad-inode-generation/bad_inode_geneartion.img.xz >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>> >>>>>>> I checked out and built v5.3-rc1 of btrfs-progs. Then ran it on my >>>>>>> mounted rootfs with linux 5.0 and captured the log (~1800 lines 209 >>>>>>> errors). >>>>>> >>>>>> It's really not recommended to run btrfs check, especially repair >>>>>> on the >>>>>> mounted fs, unless it's RO. >>>>>> >>>>>> A new transaction from kernel can easily screw up the repaired fs. >>>>>>> >>>>>>> I'm not sure if using the v5.0 kernel and/or checking mounted >>>>>>> distorts >>>>>>> the results? Else I'm going to need a live usb with a v5.3 kernel and >>>>>>> v5.3 btrfs-progs. >>>>>>> >>>>>>> If you like I can share the log. Let me know. >>>>>>> >>>>>>> This issue can potentially cause a lot of grief. Our company server >>>>>>> runs >>>>>>> Ubuntu LTS (18.04.02) with a 4.15 kernel on a btrfs boot/rootfs with >>>>>>> ~100 snapshots. I guess the problematic inodes need to be fixed on >>>>>>> each >>>>>>> snapshot prior to upgrading to 20.04 LTS (which might be on kernel >>>>>>> ~5.6)? >>>>>> >>>>>> Yes. >>>>>> >>>>>>> >>>>>>> Do I understand correctly that this FTB is caused by more strict >>>>>>> checking of the fs by the kernel, while the tools to fix the detected >>>>>>> corruptions are not yet released? >>>>>> >>>>>> Yes. >>>>>> >>>>>> Thanks, >>>>>> Qu >>>>>> >>>>> >>>> >> >