From: Nikolay Borisov <nborisov@suse.com>
To: Liu Bo <bo.liu@linux.alibaba.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 6/6] Btrfs: remove always true check in unlock_up
Date: Wed, 16 May 2018 09:47:47 +0300 [thread overview]
Message-ID: <a9d10243-012b-a517-3fe9-1821a096cad7@suse.com> (raw)
In-Reply-To: <1526406728-109055-7-git-send-email-bo.liu@linux.alibaba.com>
On 15.05.2018 20:52, Liu Bo wrote:
> @path->lock[i] is always true at this point.
You must explain why it's true. The reason is since at the beginning of
the for loop the check is performed :
if (!path->locks[i])
break;
Codewise it's ok:
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
>
> Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
> ---
> fs/btrfs/ctree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
> index f7c3f581f647..16d28a4ec54f 100644
> --- a/fs/btrfs/ctree.c
> +++ b/fs/btrfs/ctree.c
> @@ -2330,7 +2330,7 @@ static noinline void unlock_up(struct btrfs_path *path, int level,
> no_skips = 1;
>
> t = path->nodes[i];
> - if (i >= lowest_unlock && i > skip_level && path->locks[i]) {
> + if (i >= lowest_unlock && i > skip_level) {
> btrfs_tree_unlock_rw(t, path->locks[i]);
> path->locks[i] = 0;
> if (write_lock_level &&
>
next prev parent reply other threads:[~2018-05-16 6:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 17:52 [PATCH 0/6] btrfs_search_slot cleanups Liu Bo
2018-05-15 17:52 ` [PATCH 1/6] Btrfs: remove superfluous free_extent_buffer Liu Bo
2018-05-16 6:40 ` Nikolay Borisov
2018-05-15 17:52 ` [PATCH 2/6] Btrfs: use more straightforward extent_buffer_uptodate Liu Bo
2018-05-16 6:43 ` Nikolay Borisov
2018-05-18 2:09 ` Liu Bo
2018-05-15 17:52 ` [PATCH 3/6] Btrfs: move get root of btrfs_search_slot to a helper Liu Bo
2018-05-16 6:54 ` Nikolay Borisov
2018-05-15 17:52 ` [PATCH 4/6] Btrfs: remove unused check of skip_locking Liu Bo
2018-05-16 7:03 ` Nikolay Borisov
2018-05-16 7:06 ` Qu Wenruo
2018-05-18 2:55 ` Liu Bo
2018-05-18 5:36 ` Nikolay Borisov
2018-05-15 17:52 ` [PATCH 5/6] Btrfs: grab write lock directly if write_lock_level is the max level Liu Bo
2018-05-16 7:09 ` Nikolay Borisov
2018-05-15 17:52 ` [PATCH 6/6] Btrfs: remove always true check in unlock_up Liu Bo
2018-05-16 6:47 ` Nikolay Borisov [this message]
2018-05-15 18:15 ` [PATCH 0/6] btrfs_search_slot cleanups David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9d10243-012b-a517-3fe9-1821a096cad7@suse.com \
--to=nborisov@suse.com \
--cc=bo.liu@linux.alibaba.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).