From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] fstests: generic/730: exclude btrfs for now
Date: Wed, 4 Jun 2025 01:25:09 -0700 [thread overview]
Message-ID: <aEAC5WTF_tGh_RpN@infradead.org> (raw)
In-Reply-To: <20250604062509.227462-1-wqu@suse.com>
On Wed, Jun 04, 2025 at 03:55:09PM +0930, Qu Wenruo wrote:
> - Btrfs doesn't support shutdown callbacks
>
> - The current shutdown callbacks are per-fs
The callsbacks are per-block device.
> Meanwhile btrfs is a multi-device fs, it needs to know which block
> device is triggerring shutdown, and needs to do extra evaluation
> (e.g. can the remaining devices support RW operations) before
> triggering a full fs shutdown.
Exactly for that reason.
> +++ b/tests/generic/730
> @@ -26,6 +26,10 @@ _require_test
> _require_block_device $TEST_DEV
> _require_scsi_debug
>
> +if [ "$FSTYP" = "btrfs" ]; then
> + _notrun "btrfs doesn't support per-fs shutdown yet"
> +fi
Please don't add these horrible fs excludes to tests. Add a helper
in common to check if something is supported.
next prev parent reply other threads:[~2025-06-04 8:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 6:25 [PATCH] fstests: generic/730: exclude btrfs for now Qu Wenruo
2025-06-04 8:25 ` Christoph Hellwig [this message]
2025-06-04 9:17 ` Qu Wenruo
2025-06-04 13:24 ` Christoph Hellwig
2025-06-06 10:55 ` Qu Wenruo
2025-06-05 13:55 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aEAC5WTF_tGh_RpN@infradead.org \
--to=hch@infradead.org \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox