From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92C114A23 for ; Mon, 30 Jun 2025 05:49:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751262572; cv=none; b=gBTrmaMfR1TpXYnkYX0adZ4gC3Oa+lhTIKjGkvgeI07FVgKG+hSMcFa/1caWxzYF8Bv1u5mTqkSUI9vEIwxUUCrjE5tIgQ1aZYcX8Vibsc6VoB7zFgMKSyXOG+5bPHAZPLwcNIKhsmiXDYgaIDmkRGrJ9oN+qJJVCW/NmLuOzrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751262572; c=relaxed/simple; bh=JsfS8Wl1XrREMocPalThvdKppx90e2nJ0DEMdXXK6h0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ADZyR6mH0nZDM5dvIvJ21cwYOrRqeDJwjEmr0uH9uBq/epg+a9nO4BVBVAxpHKgSa97GJfj1PwS4cTtfnicDOP88voqjM8bM7iicOlzhOatkGJJmpE6a+quTz/W/0NhTtE4lQaLCL7xdtmOW3pQxXILyPUXrFCMdoW/PQTwSFJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=mQaU63iD; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="mQaU63iD" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=PlS3DOu6s5fsp0auZQjO79xIT8e2BjeSJdKj5vwdvY4=; b=mQaU63iDJ8U/JXBusWD2ThMM2s 5KZs9+aslFr7nYnYPvmb8rJ/UJT0aN4906Llirfg9xhFqpnQbSaQBuyKGqhxjLrgaIKkPQ/RtJrtL SsJUVHkTgf3Qve/9AWj4w9bCn6V1f9bwrpPXbPmaOhvxF79qQTh5LANLLOkIhyz7gsNzntkU2pfNt 2opGYfg0uqVfN4FrrNrIYOeBs6G6o/DBkG/IzwMYMFWvqA4B0+eXOyGVBRm8gajWW4ji5R57IwdMY OgxOFmGGWT+1Hj13goathc+n7wseAYoSgUEW6O2ctmFiR8WtpbLU09STkN8yb+1Zhl87zzKzHib2G zUG9/WKw==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uW7OS-00000001HyW-0nwz; Mon, 30 Jun 2025 05:49:28 +0000 Date: Sun, 29 Jun 2025 22:49:28 -0700 From: Christoph Hellwig To: Qu Wenruo Cc: Christoph Hellwig , linux-btrfs@vger.kernel.org Subject: Re: [PATCH v6 0/8] btrfs: use fs_holder_ops for btrfs Message-ID: References: <2ddf32ff-7411-4325-9ce2-116f4c5f6362@suse.com> Precedence: bulk X-Mailing-List: linux-btrfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2ddf32ff-7411-4325-9ce2-116f4c5f6362@suse.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Mon, Jun 30, 2025 at 03:13:11PM +0930, Qu Wenruo wrote: > > > 在 2025/6/30 15:10, Christoph Hellwig 写道: > > Looks like this doesn't add the remove_dev method and thus does the > > wrong thing when a device underlying a raid configuration gets removed? > > > > The remove_bdev() callback is a completely different patchset, which depends > on the btrfs shutdown support. > > This series is only for the blk_holder_ops, and will be the basis for the > remove_bdev() series. Oh, right. Without ->shutdown we're not getting any shutdown at all so things should be fine. Sorry for the noise.