Re: [PATCH] btrfs: zoned: skip ZONE FINISH of conventional zones

[Johannes Thumshirn <morbidrsa@gmail.com>]

On Thu, Jul 24, 2025 at 08:56:43AM +0900, Damien Le Moal wrote:
> > +	if (!device->bdev)
> > +		return 0;
> > +
> > +	if (zinfo->max_active_zones == 0)
> > +		return 0;
> 
> Should these 2 returns be replaced with a "goto out;"...
> 
> > +
> > +	if (btrfs_dev_is_sequential(device, physical)) {
> > +		unsigned int nofs_flags;
> > +
> > +		nofs_flags = memalloc_nofs_save();
> > +		ret = blkdev_zone_mgmt(device->bdev, REQ_OP_ZONE_FINISH,
> > +				       physical >> SECTOR_SHIFT,
> > +				       zinfo->zone_size >> SECTOR_SHIFT);
> > +		memalloc_nofs_restore(nofs_flags);
> > +
> > +		if (ret)
> > +			return ret;
> > +	}
> > +
> 
> With "out:" label here ?
> 
> That was not done before, but I wonder if that is needed.
> 
> > +	if (!(block_group->flags & BTRFS_BLOCK_GROUP_DATA))
> > +		zinfo->reserved_active_zones++;
> > +	btrfs_dev_clear_active_zone(device, physical);

I don't think so. If device->bdev == NULL it means the device is missing and
we can't do anything with it. If zone_info->max_active_zones == 0, it means we
don't do active zone tracking on that device.