From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: get rid of btrfs_dio_private
Date: Mon, 20 Oct 2025 00:27:10 -0700 [thread overview]
Message-ID: <aPXkTrGQ5DPnM5HT@infradead.org> (raw)
In-Reply-To: <2912ce5f-fb54-4681-b001-112fa26b062d@suse.com>
On Mon, Oct 20, 2025 at 05:46:23PM +1030, Qu Wenruo wrote:
>
> It looks like the bbio->file_offset is not safe, as btrfs_split_bio() can
> modify the original file offset, causing some bio ranges not properly
> released during dio reads.
>
> Please ignore the patchset for now, we really want some stable
> file_offset/size that will not change due to split.
You can't make them stable because they must change for splits.
You could do what XFS/iomapo do: split the ordered extents on bio
boundaries, and then in the completion handler merge them again
for more efficient handling if there are enough queued up.
prev parent reply other threads:[~2025-10-20 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 5:57 [PATCH] btrfs: get rid of btrfs_dio_private Qu Wenruo
2025-10-20 7:11 ` Johannes Thumshirn
2025-10-20 7:16 ` Qu Wenruo
2025-10-20 7:27 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPXkTrGQ5DPnM5HT@infradead.org \
--to=hch@infradead.org \
--cc=Johannes.Thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox