From: Christoph Hellwig <hch@infradead.org>
To: Jani Partanen <jiipee@sotapeli.fi>
Cc: Christoph Hellwig <hch@infradead.org>,
Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
clm@fb.comi, dsterba@suse.com, terrelln@fb.com,
herbert@gondor.apana.org.au, linux-btrfs@vger.kernel.org,
linux-crypto@vger.kernel.org, qat-linux@intel.com, cyan@meta.com,
brian.will@intel.com, weigang.li@intel.com,
senozhatsky@chromium.org
Subject: Re: [RFC PATCH 00/16] btrfs: offload compression to hardware accelerators
Date: Tue, 2 Dec 2025 23:00:05 -0800 [thread overview]
Message-ID: <aS_f9axsi0QmmhiL@infradead.org> (raw)
In-Reply-To: <8d3e44b0-23d8-4493-8e7e-33bbe1d904ef@sotapeli.fi>
On Tue, Dec 02, 2025 at 05:46:29PM +0200, Jani Partanen wrote:
>
> On 02/12/2025 9.53, Christoph Hellwig wrote:
> > On Fri, Nov 28, 2025 at 07:04:48PM +0000, Giovanni Cabiddu wrote:
> > > +---------------------------+---------+---------+---------+---------+
> > > | | QAT-L9 | ZSTD-L3 | ZLIB-L3 | LZO-L1 |
> > > +---------------------------+---------+---------+---------+---------+
> > > | Disk Write TPUT (GiB/s) | 6.5 | 5.2 | 2.2 | 6.5 |
> > > +---------------------------+---------+---------+---------+---------+
> > > | CPU utils %age @208 cores | 4.56% | 15.67% | 12.79% | 19.85% |
> > > +---------------------------+---------+---------+---------+---------+
> > > | Compression Ratio | 34% | 35% | 37% | 58% |
> > > +---------------------------+---------+---------+---------+---------+
> > Is it just me, or do the numbers not look all that great at least
> > when comparing to ZSTD-L3 and LZO-L1? What are the decompression
> > numbers?
> >
>
> What makes you think so?
Well, if you compared QAT-L9 to LZO-L1 specifically:
- yes, cpu usage is reduced to a quarter
- disk performance is the same
- the compression ratio is much, much worse
and we don't know anything about the decompression speed.
All the while you significantly complicate the code.
next prev parent reply other threads:[~2025-12-03 7:00 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 19:04 [RFC PATCH 00/16] btrfs: offload compression to hardware accelerators Giovanni Cabiddu
2025-11-28 14:25 ` Giovanni Cabiddu
2025-11-28 16:13 ` Chris Mason
2025-11-28 19:04 ` [RFC PATCH 01/16] crypto: zstd - fix double-free in per-CPU stream cleanup Giovanni Cabiddu
2025-11-28 19:04 ` [RFC PATCH 02/16] Revert "crypto: qat - remove unused macros in qat_comp_alg.c" Giovanni Cabiddu
2025-11-28 19:04 ` [RFC PATCH 03/16] Revert "crypto: qat - Remove zlib-deflate" Giovanni Cabiddu
2025-11-28 19:04 ` [RFC PATCH 04/16] crypto: qat - use memcpy_*_sglist() in zlib deflate Giovanni Cabiddu
2025-11-28 19:04 ` [RFC PATCH 05/16] Revert "crypto: testmgr - Remove zlib-deflate" Giovanni Cabiddu
2025-11-28 19:04 ` [RFC PATCH 06/16] crypto: deflate - add support for deflate rfc1950 (zlib) Giovanni Cabiddu
2025-11-28 19:04 ` [RFC PATCH 07/16] crypto: scomp - Add setparam interface Giovanni Cabiddu
2025-11-28 19:04 ` [RFC PATCH 08/16] crypto: acomp " Giovanni Cabiddu
2025-11-28 19:04 ` [RFC PATCH 09/16] crypto: acomp - Add comp_params helpers Giovanni Cabiddu
2025-11-28 19:04 ` [RFC PATCH 10/16] crypto: acomp - add NUMA-aware stream allocation Giovanni Cabiddu
2025-11-28 19:04 ` [RFC PATCH 11/16] crypto: deflate - add support for compression levels Giovanni Cabiddu
2025-11-28 19:05 ` [RFC PATCH 12/16] crypto: zstd " Giovanni Cabiddu
2025-11-28 19:05 ` [RFC PATCH 13/16] crypto: qat - increase number of preallocated sgl descriptors Giovanni Cabiddu
2025-11-28 19:05 ` [RFC PATCH 14/16] crypto: qat - add support for zstd Giovanni Cabiddu
2025-11-28 19:05 ` [RFC PATCH 15/16] crypto: qat - add support for compression levels Giovanni Cabiddu
2025-11-28 19:05 ` [RFC PATCH 16/16] btrfs: add compression hw-accelerated offload Giovanni Cabiddu
2025-11-28 21:55 ` Qu Wenruo
2025-11-28 22:40 ` Giovanni Cabiddu
2025-11-28 23:59 ` Qu Wenruo
2025-11-29 0:23 ` Qu Wenruo
2025-12-01 14:32 ` Giovanni Cabiddu
2025-12-01 15:10 ` Giovanni Cabiddu
2025-12-01 20:57 ` Qu Wenruo
2025-12-01 22:18 ` Giovanni Cabiddu
2025-12-01 23:13 ` Qu Wenruo
2025-12-02 17:09 ` Giovanni Cabiddu
2025-12-02 20:38 ` Qu Wenruo
2025-12-02 22:37 ` Giovanni Cabiddu
2025-12-02 22:59 ` Qu Wenruo
2025-11-29 1:00 ` David Sterba
2025-11-29 1:08 ` David Sterba
2025-12-02 7:53 ` [RFC PATCH 00/16] btrfs: offload compression to hardware accelerators Christoph Hellwig
2025-12-02 15:46 ` Jani Partanen
2025-12-02 17:19 ` Giovanni Cabiddu
2025-12-03 7:00 ` Christoph Hellwig [this message]
2025-12-03 10:15 ` Giovanni Cabiddu
2025-12-04 9:59 ` Christoph Hellwig
2025-12-03 10:47 ` Simon Richter
2025-12-04 10:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aS_f9axsi0QmmhiL@infradead.org \
--to=hch@infradead.org \
--cc=brian.will@intel.com \
--cc=clm@fb.comi \
--cc=cyan@meta.com \
--cc=dsterba@suse.com \
--cc=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=jiipee@sotapeli.fi \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=senozhatsky@chromium.org \
--cc=terrelln@fb.com \
--cc=weigang.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox