From: Christoph Hellwig <hch@infradead.org>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: raid56: fix memory leak of btrfs_raid_bio::stripe_uptodate_bitmap
Date: Sun, 1 Feb 2026 22:24:59 -0800 [thread overview]
Message-ID: <aYBDO6g5JB8F9Vvm@infradead.org> (raw)
In-Reply-To: <140aedc1e1af2866bb838d29b742c2015d55d91e.1769793280.git.fdmanana@suse.com>
On Fri, Jan 30, 2026 at 05:14:59PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> We allocate the bitmap but we never free it in free_raid_bio_pointers().
> Fix this by adding a bitmap_free() call against the stripe_uptodate_bitmap
> of a raid bio.
>
> Fixes: 1810350b04ef ("btrfs: raid56: move sector_ptr::uptodate into a dedicated bitmap")
> Reported-by: Christoph Hellwig <hch@lst.de>
> Link: https://lore.kernel.org/linux-btrfs/20260126045315.GA31641@lst.de/
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
This works there, thanks!
Tested-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2026-02-02 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 17:14 [PATCH] btrfs: raid56: fix memory leak of btrfs_raid_bio::stripe_uptodate_bitmap fdmanana
2026-01-30 20:38 ` Qu Wenruo
2026-02-02 6:24 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYBDO6g5JB8F9Vvm@infradead.org \
--to=hch@infradead.org \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox