public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dominique Martinet <asmadeus@codewreck.org>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christoph Anton Mitterer <calestyo@scientia.org>,
	Qu Wenruo <wqu@suse.com>,
	linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: We have a space info key for a block group that doesn't exist
Date: Tue, 3 Feb 2026 16:06:42 +0900	[thread overview]
Message-ID: <aYGeghb0lkhZhDcV@codewreck.org> (raw)
In-Reply-To: <fc2f1d31-7f2c-493f-be42-2cb8c1fd5a17@gmx.com>

Hi Qu,

Qu Wenruo wrote on Wed, Nov 19, 2025 at 09:59:55AM +1030:
>>> We have a space info key for a block group that doesn't exist
>>
>> So even without clearing the cache as you've proposed below, it
>> couldn't have caused any post or future corruption, right?!
> 
> Yep. Allocation is always happening based on a block group, such
> orphan space info/bitmap keys won't cause the allocator to use it
> anyway.
> 
> So no corruption or whatever.

We're running rountine btrfsck before copying the filesystem for cloning
in one of our tools, and I'm starting to get user reports of errors due
to this error (we run an ancient 5.10 kernel but there hadn't been any
such report, and now we just got two in a couple of weeks so something
must have been backported to the stable tree...)

Anyway, I agree with your answer that it's safe to ignore, but it's not
obvious for users to decide that, so I'd like to address this somehow.

If it's really harmless, could it be printed as info message but not
change the btrfsck return code? (e.g. if that's the only error, return
success)

If you think it's worth keeping as an error, would you (or someone else)
happen to have any idea where I should start looking?


(Alternatively since we're not copying at the block level I guess there's
no real need for this check in the first place, as any real corruption
would cause IO error, and I could just forget about this... The check
was just ported e2fsck from back when the fs was ext4...)

Thanks,
-- 
Dominique Martinet | Asmadeus

  reply	other threads:[~2026-02-03  7:07 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17  2:08 We have a space info key for a block group that doesn't exist Christoph Anton Mitterer
2025-11-17  2:18 ` Qu Wenruo
2025-11-18 23:27   ` Christoph Anton Mitterer
2025-11-18 23:29     ` Qu Wenruo
2026-02-03  7:06       ` Dominique Martinet [this message]
2026-02-03  7:47         ` Qu Wenruo
2026-02-03  8:17           ` Dominique Martinet
2026-02-05  1:44       ` Christoph Anton Mitterer
2026-02-05  4:24         ` Qu Wenruo
2026-02-05  4:30           ` Christoph Anton Mitterer
2026-02-05  4:43             ` Qu Wenruo
2026-02-05  4:50               ` Christoph Anton Mitterer
2026-02-05  4:53                 ` Qu Wenruo
2026-02-05 14:48                   ` Christoph Anton Mitterer
2026-02-05 20:48                     ` Qu Wenruo
2026-02-05 23:56                       ` Christoph Anton Mitterer
2026-02-06  3:45                         ` Qu Wenruo
2026-02-07  1:19                           ` Christoph Anton Mitterer
2026-02-07  1:27                             ` Christoph Anton Mitterer
2026-02-07  2:34                               ` Qu Wenruo
2026-02-07  5:00                                 ` Christoph Anton Mitterer
2026-02-07 16:47                                   ` space_info METADATA (sub-group id 0) has 691535872 free, is not full // open_ctree failed: -2 Christoph Anton Mitterer
2026-02-09  3:21                                     ` Qu Wenruo
2026-02-09  3:32                                       ` Christoph Anton Mitterer
2026-02-09  3:48                                         ` Qu Wenruo
2026-02-09  3:58                                           ` Christoph Anton Mitterer
2026-02-09  4:02                                             ` Qu Wenruo
2026-02-10  0:14                                               ` Christoph Anton Mitterer
2026-02-10 22:49                                                 ` Christoph Anton Mitterer
2026-03-04  3:59                                                   ` Christoph Anton Mitterer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYGeghb0lkhZhDcV@codewreck.org \
    --to=asmadeus@codewreck.org \
    --cc=calestyo@scientia.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox