Re: [PATCH] btrfs: fix incorrect error message in check_dev_extent_item()

[Boris Burkov <boris@bur.io>]

On Tue, Feb 17, 2026 at 10:34:08AM +0000, Mark Harmstone wrote:
> Fix the error message in check_dev_extent_item(), when an overlapping
> stripe is encountered. For dev extents, objectid is the disk number and
> offset the physical address, so prev_key->objectid should actually be
> prev_key->offset.
> 
> (I can't take any credit for this one - this was discovered by Chris and
> his friend Claude.)
> 
> Signed-off-by: Mark Harmstone <mark@harmstone.com>
> Suggested-by: Chris Mason <clm@fb.com>

Reviewed-by: Boris Burkov <boris@bur.io>

> Fixes: 008e2512dc56 ("btrfs: tree-checker: add dev extent item checks")
> ---
>  fs/btrfs/tree-checker.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/tree-checker.c b/fs/btrfs/tree-checker.c
> index 452394b34d01..9774779f060b 100644
> --- a/fs/btrfs/tree-checker.c
> +++ b/fs/btrfs/tree-checker.c
> @@ -1921,7 +1921,7 @@ static int check_dev_extent_item(const struct extent_buffer *leaf,
>  		if (unlikely(prev_key->offset + prev_len > key->offset)) {
>  			generic_err(leaf, slot,
>  		"dev extent overlap, prev offset %llu len %llu current offset %llu",
> -				    prev_key->objectid, prev_len, key->offset);
> +				    prev_key->offset, prev_len, key->offset);
>  			return -EUCLEAN;
>  		}
>  	}
> -- 
> 2.52.0
>