From: Qu Wenruo <wqu@suse.com>
To: Christoph Hellwig <hch@lst.de>, Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 4/7] btrfs: introduce new read-repair infrastructure
Date: Thu, 26 May 2022 15:52:03 +0800 [thread overview]
Message-ID: <aa251ce8-e97d-8b38-b9f5-421b95fa79a0@suse.com> (raw)
In-Reply-To: <20220526074536.GA25911@lst.de>
On 2022/5/26 15:45, Christoph Hellwig wrote:
> On Thu, May 26, 2022 at 03:37:47PM +0800, Qu Wenruo wrote:
>> Rare case doesn't mean it won't happen.
>>
>> We still need to address it anyway.
>
> address != build overly complicated code to optimize for it
>
Well, using seemly simple code, but can lead to read way more loops and
way more data to read, is neither a good way.
next prev parent reply other threads:[~2022-05-26 7:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 10:59 [PATCH v2 0/7] btrfs: read-repair rework based on bitmap Qu Wenruo
2022-05-25 10:59 ` [PATCH v2 1/7] btrfs: save the original bi_iter into btrfs_bio for buffered read Qu Wenruo
2022-05-25 10:59 ` [PATCH v2 2/7] btrfs: make repair_io_failure available outside of extent_io.c Qu Wenruo
2022-05-25 10:59 ` [PATCH v2 3/7] btrfs: add a btrfs_map_bio_wait helper Qu Wenruo
2022-05-25 10:59 ` [PATCH v2 4/7] btrfs: introduce new read-repair infrastructure Qu Wenruo
2022-05-26 3:06 ` Qu Wenruo
2022-05-26 7:30 ` Christoph Hellwig
2022-05-26 7:37 ` Qu Wenruo
2022-05-26 7:45 ` Christoph Hellwig
2022-05-26 7:52 ` Qu Wenruo [this message]
2022-05-26 8:00 ` Christoph Hellwig
2022-05-26 8:07 ` Qu Wenruo
2022-05-26 8:17 ` Christoph Hellwig
2022-05-26 8:26 ` Qu Wenruo
2022-05-26 8:28 ` Christoph Hellwig
2022-05-26 8:49 ` Qu Wenruo
2022-05-26 8:54 ` Christoph Hellwig
2022-05-26 9:13 ` Qu Wenruo
2022-05-27 8:10 ` Christoph Hellwig
2022-05-25 10:59 ` [PATCH v2 5/7] btrfs: make buffered read path to use the new read repair infrastructure Qu Wenruo
2022-05-25 10:59 ` [PATCH v2 6/7] btrfs: make direct io " Qu Wenruo
2022-05-25 10:59 ` [PATCH v2 7/7] btrfs: remove io_failure_record infrastructure completely Qu Wenruo
2022-05-25 14:55 ` [PATCH v2 0/7] btrfs: read-repair rework based on bitmap David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa251ce8-e97d-8b38-b9f5-421b95fa79a0@suse.com \
--to=wqu@suse.com \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox