Re: [PATCH 06/11] btrfs: include linux/crc32c in dir-item and inode-item

[Anand Jain <anand.jain@oracle.com>]

On 8/23/23 21:51, Josef Bacik wrote:
> Now these are holding the crc32c wrappers, add the required include so
> that we have our necessary dependencies.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
>   fs/btrfs/dir-item.h   | 2 ++
>   fs/btrfs/inode-item.h | 1 +
>   2 files changed, 3 insertions(+)
> 
> diff --git a/fs/btrfs/dir-item.h b/fs/btrfs/dir-item.h
> index 951b4dda46fe..5db2ea0dfd76 100644
> --- a/fs/btrfs/dir-item.h
> +++ b/fs/btrfs/dir-item.h
> @@ -3,6 +3,8 @@
>   #ifndef BTRFS_DIR_ITEM_H
>   #define BTRFS_DIR_ITEM_H
>   
> +#include <linux/crc32c.h>
> +
>   int btrfs_check_dir_item_collision(struct btrfs_root *root, u64 dir,
>   			  const struct fscrypt_str *name);
>   int btrfs_insert_dir_item(struct btrfs_trans_handle *trans,


This could be merged into Patch 4/11.

> diff --git a/fs/btrfs/inode-item.h b/fs/btrfs/inode-item.h
> index 2ee425a08e63..63dfd227e7ce 100644
> --- a/fs/btrfs/inode-item.h
> +++ b/fs/btrfs/inode-item.h
> @@ -4,6 +4,7 @@
>   #define BTRFS_INODE_ITEM_H
>   
>   #include <linux/types.h>
> +#include <linux/crc32c.h>
>   
>   struct btrfs_trans_handle;
>   struct btrfs_root;


And, this can be merged into Patch 3/11.

Otherwise, changes looks fine.

Reviewed-by: Anand Jain <anand.jain@oracle.com>