* [PATCH] btrfs: use common helper instead of open coding a bit test
@ 2018-09-21 12:26 David Sterba
2018-09-21 17:55 ` Nikolay Borisov
0 siblings, 1 reply; 2+ messages in thread
From: David Sterba @ 2018-09-21 12:26 UTC (permalink / raw)
To: linux-btrfs; +Cc: David Sterba
The helper does the same math and we take care about the special case
when flags is 0 too.
Signed-off-by: David Sterba <dsterba@suse.com>
---
fs/btrfs/volumes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 909c578506ee..26eb388db343 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -3691,7 +3691,7 @@ static int alloc_profile_is_valid(u64 flags, int extended)
return !extended; /* "0" is valid for usual profiles */
/* true if exactly one bit set */
- return (flags & (flags - 1)) == 0;
+ return is_power_of_2(flags);
}
static inline int balance_need_close(struct btrfs_fs_info *fs_info)
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: use common helper instead of open coding a bit test
2018-09-21 12:26 [PATCH] btrfs: use common helper instead of open coding a bit test David Sterba
@ 2018-09-21 17:55 ` Nikolay Borisov
0 siblings, 0 replies; 2+ messages in thread
From: Nikolay Borisov @ 2018-09-21 17:55 UTC (permalink / raw)
To: David Sterba, linux-btrfs
On 21.09.2018 15:26, David Sterba wrote:
> The helper does the same math and we take care about the special case
> when flags is 0 too.
>
> Signed-off-by: David Sterba <dsterba@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/volumes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 909c578506ee..26eb388db343 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -3691,7 +3691,7 @@ static int alloc_profile_is_valid(u64 flags, int extended)
> return !extended; /* "0" is valid for usual profiles */
>
> /* true if exactly one bit set */
> - return (flags & (flags - 1)) == 0;
> + return is_power_of_2(flags);
> }
>
> static inline int balance_need_close(struct btrfs_fs_info *fs_info)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-21 23:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-21 12:26 [PATCH] btrfs: use common helper instead of open coding a bit test David Sterba
2018-09-21 17:55 ` Nikolay Borisov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).