From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs: rename btrfs_folio_(set|start|end)_writer_lock()
Date: Wed, 9 Oct 2024 07:28:51 +1030 [thread overview]
Message-ID: <ab5ed1db-7785-404c-a20d-7f11c3346eb6@gmx.com> (raw)
In-Reply-To: <20241008170916.GF1609@twin.jikos.cz>
在 2024/10/9 03:39, David Sterba 写道:
> On Tue, Oct 08, 2024 at 08:28:45AM +1030, Qu Wenruo wrote:
>> Since there is no user of reader locks, rename the writer locks into a
>> more generic name, by removing the "_writer" part from the name.
>>
>> And also rename btrfs_subpage::writer into btrfs_subpage::locked.
>
> 'locked' looks confusing in connection with atomics. It sounds like a
> predicate but is in fact a counter, so I'd suggest to rename it to
> nr_locked or nr_locks or something like that.
>
nr_locked looks much better, and way better than my original
"sectors_locked".
Thanks,
Qu
prev parent reply other threads:[~2024-10-08 20:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 21:58 [PATCH 0/2] btrfs: unify the read and writer locks for btrfs_subpage Qu Wenruo
2024-10-07 21:58 ` [PATCH 1/2] btrfs: unify to use writer locks for subpage locking Qu Wenruo
2024-10-07 21:58 ` [PATCH 2/2] btrfs: rename btrfs_folio_(set|start|end)_writer_lock() Qu Wenruo
2024-10-08 17:09 ` David Sterba
2024-10-08 20:58 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab5ed1db-7785-404c-a20d-7f11c3346eb6@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).