From: Nikolay Borisov <nborisov@suse.com>
To: Timofey Titovets <nefelim4ag@gmail.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: compress_file_range() remove dead variable num_bytes
Date: Tue, 26 Sep 2017 12:24:47 +0300 [thread overview]
Message-ID: <ac3b4cef-7099-a67b-4d78-03fcde34c9e8@suse.com> (raw)
In-Reply-To: <20170911211517.22441-1-nefelim4ag@gmail.com>
On 12.09.2017 00:15, Timofey Titovets wrote:
> Remove dead assigment of num_bytes
>
> Also as num_bytes only used in will_compress block as
> copy of total_in just replace that with total_in and drop num_bytes entire
>
> Signed-off-by: Timofey Titovets <nefelim4ag@gmail.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
> ---
> fs/btrfs/inode.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 17ad018da0a2..1ff4fa461555 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -446,7 +446,6 @@ static noinline void compress_file_range(struct inode *inode,
> {
> struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb);
> struct btrfs_root *root = BTRFS_I(inode)->root;
> - u64 num_bytes;
> u64 blocksize = fs_info->sectorsize;
> u64 actual_end;
> u64 isize = i_size_read(inode);
> @@ -496,8 +495,6 @@ static noinline void compress_file_range(struct inode *inode,
>
> total_compressed = min_t(unsigned long, total_compressed,
> BTRFS_MAX_UNCOMPRESSED);
> - num_bytes = ALIGN(end - start + 1, blocksize);
> - num_bytes = max(blocksize, num_bytes);
> total_in = 0;
> ret = 0;
>
> @@ -613,7 +610,6 @@ static noinline void compress_file_range(struct inode *inode,
> */
> total_in = ALIGN(total_in, PAGE_SIZE);
> if (total_compressed + blocksize <= total_in) {
> - num_bytes = total_in;
> *num_added += 1;
>
> /*
> @@ -621,12 +617,12 @@ static noinline void compress_file_range(struct inode *inode,
> * allocation on disk for these compressed pages, and
> * will submit them to the elevator.
> */
> - add_async_extent(async_cow, start, num_bytes,
> + add_async_extent(async_cow, start, total_in,
> total_compressed, pages, nr_pages,
> compress_type);
>
> - if (start + num_bytes < end) {
> - start += num_bytes;
> + if (start + total_in < end) {
> + start += total_in;
> pages = NULL;
> cond_resched();
> goto again;
>
prev parent reply other threads:[~2017-09-26 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 21:15 [PATCH] Btrfs: compress_file_range() remove dead variable num_bytes Timofey Titovets
2017-09-26 9:24 ` Nikolay Borisov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac3b4cef-7099-a67b-4d78-03fcde34c9e8@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nefelim4ag@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).