linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Borisov <nborisov@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 00/10] Simplify function interfaces
Date: Wed, 2 May 2018 08:50:54 +0300	[thread overview]
Message-ID: <acf480fc-bc16-7af7-7827-45f29490a180@suse.com> (raw)
In-Reply-To: <1522135172-8276-1-git-send-email-nborisov@suse.com>



On 27.03.2018 10:19, Nikolay Borisov wrote:
> A bunch of functions in lowmem mode take an 'ext_ref' parameter only to pass it
> down the call chain where it eventually is consumed. Turns out the functions
> which actually check the parameter are find_inode_ref and check_inode_item, the
> are only passing it down to them. At the same time those functions can get a 
> reference to fs_info and do the check in them at the appropriate time. 
> 
> This patchset cleanups the interface of various function by dropping the 
> ext_ref argument and moving the actual query of the EXTREF feature closer to 
> where it's being used. 
> 
> The final patch just changes signature of __btrfs_fs_incompat to better match 
> the logic of the code and be identical to its kernel counterpart. All in all 
> this series doesn't introduce any functional changes per-se.
> 
> Nikolay Borisov (10):
>   btrfs-progs: Drop ext_ref parameter from find_inode_ref
>   btrfs-progs: Drop ext_ref param from check_dir_item
>   btrfs-progs: Drop ext_ref argument from check_inode_item
>   btrfs-progs: Drop unused ext_ref parameter from process_one_leaf
>   btrfs-progs: Remove ext_ref param from check_fs_first_inode
>   btrfs-progs: Remove ext_ref param from walk_down_tree
>   btrfs-progs: Drop ext_ref param from check_fs_first_inode
>   btrfs-progs: Drop ext_ref arument from check_fs_root
>   btrfs-progs: Remove ext_ref local variable from check_fs_roots_lowmem
>   btrfs-progs: Make __btrfs_fs_incompat return bool
> 
>  check/mode-lowmem.c | 63 +++++++++++++++++++++++------------------------------
>  ctree.h             |  2 +-
>  2 files changed, 28 insertions(+), 37 deletions(-)

Ping
> 

  parent reply	other threads:[~2018-05-02  5:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-27  7:19 [PATCH 00/10] Simplify function interfaces Nikolay Borisov
2018-03-27  7:19 ` [PATCH 01/10] btrfs-progs: Drop ext_ref parameter from find_inode_ref Nikolay Borisov
2018-03-27  7:19 ` [PATCH 02/10] btrfs-progs: Drop ext_ref param from check_dir_item Nikolay Borisov
2018-03-27  7:19 ` [PATCH 03/10] btrfs-progs: Drop ext_ref argument from check_inode_item Nikolay Borisov
2018-03-27  7:19 ` [PATCH 04/10] btrfs-progs: Drop unused ext_ref parameter from process_one_leaf Nikolay Borisov
2018-03-27  7:19 ` [PATCH 05/10] btrfs-progs: Remove ext_ref param from check_fs_first_inode Nikolay Borisov
2018-03-27  7:19 ` [PATCH 06/10] btrfs-progs: Remove ext_ref param from walk_down_tree Nikolay Borisov
2018-03-27  7:19 ` [PATCH 07/10] btrfs-progs: Drop ext_ref param from check_fs_first_inode Nikolay Borisov
2018-03-27  7:19 ` [PATCH 08/10] btrfs-progs: Drop ext_ref arument from check_fs_root Nikolay Borisov
2018-03-27  7:19 ` [PATCH 09/10] btrfs-progs: Remove ext_ref local variable from check_fs_roots_lowmem Nikolay Borisov
2018-03-27  7:19 ` [PATCH 10/10] btrfs-progs: Make __btrfs_fs_incompat return bool Nikolay Borisov
2018-03-27  7:38 ` [PATCH 00/10] Simplify function interfaces Su Yue
2018-05-02  5:50 ` Nikolay Borisov [this message]
2018-05-09 11:34   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acf480fc-bc16-7af7-7827-45f29490a180@suse.com \
    --to=nborisov@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).