From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:38078 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999AbeEBFuz (ORCPT ); Wed, 2 May 2018 01:50:55 -0400 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C1B95AD01 for ; Wed, 2 May 2018 05:50:54 +0000 (UTC) Subject: Re: [PATCH 00/10] Simplify function interfaces To: linux-btrfs@vger.kernel.org References: <1522135172-8276-1-git-send-email-nborisov@suse.com> From: Nikolay Borisov Message-ID: Date: Wed, 2 May 2018 08:50:54 +0300 MIME-Version: 1.0 In-Reply-To: <1522135172-8276-1-git-send-email-nborisov@suse.com> Content-Type: text/plain; charset=utf-8 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 27.03.2018 10:19, Nikolay Borisov wrote: > A bunch of functions in lowmem mode take an 'ext_ref' parameter only to pass it > down the call chain where it eventually is consumed. Turns out the functions > which actually check the parameter are find_inode_ref and check_inode_item, the > are only passing it down to them. At the same time those functions can get a > reference to fs_info and do the check in them at the appropriate time. > > This patchset cleanups the interface of various function by dropping the > ext_ref argument and moving the actual query of the EXTREF feature closer to > where it's being used. > > The final patch just changes signature of __btrfs_fs_incompat to better match > the logic of the code and be identical to its kernel counterpart. All in all > this series doesn't introduce any functional changes per-se. > > Nikolay Borisov (10): > btrfs-progs: Drop ext_ref parameter from find_inode_ref > btrfs-progs: Drop ext_ref param from check_dir_item > btrfs-progs: Drop ext_ref argument from check_inode_item > btrfs-progs: Drop unused ext_ref parameter from process_one_leaf > btrfs-progs: Remove ext_ref param from check_fs_first_inode > btrfs-progs: Remove ext_ref param from walk_down_tree > btrfs-progs: Drop ext_ref param from check_fs_first_inode > btrfs-progs: Drop ext_ref arument from check_fs_root > btrfs-progs: Remove ext_ref local variable from check_fs_roots_lowmem > btrfs-progs: Make __btrfs_fs_incompat return bool > > check/mode-lowmem.c | 63 +++++++++++++++++++++++------------------------------ > ctree.h | 2 +- > 2 files changed, 28 insertions(+), 37 deletions(-) Ping >