Re: [PATCH] btrfs: Remove obsolete function declaration

[Qu Wenruo <wqu@suse.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1443 bytes --]



On 2018年03月21日 15:03, Nikolay Borisov wrote:
> This function was removed in 24bc2843edd5 ("btrfs:
> Refactor __get_raid_index() to btrfs_bg_flags_to_raid_index()") what
> remains is a defunct declaration. Remove it.

Nice find, thanks for get this.


But strangely, I just fetched David's repo, but didn't find that commit
hash anywhere.

I'm fetching from git.kernel.org repo, or is that repo only updated when
pushing to Linus?

Thanks,
Qu

> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
> David, 
> 
> This is a fixlet to the aforementioned patch which is only in your misc-next, 
> I'd suggest just squash this fixlet into the original one. 
> 
>  fs/btrfs/ctree.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
> index fbe51edb9cac..03be51d77357 100644
> --- a/fs/btrfs/ctree.h
> +++ b/fs/btrfs/ctree.h
> @@ -2801,7 +2801,6 @@ int btrfs_trim_fs(struct btrfs_fs_info *fs_info, struct fstrim_range *range);
>  int btrfs_init_space_info(struct btrfs_fs_info *fs_info);
>  int btrfs_delayed_refs_qgroup_accounting(struct btrfs_trans_handle *trans,
>  					 struct btrfs_fs_info *fs_info);
> -int __get_raid_index(u64 flags);
>  int btrfs_start_write_no_snapshotting(struct btrfs_root *root);
>  void btrfs_end_write_no_snapshotting(struct btrfs_root *root);
>  void btrfs_wait_for_snapshot_creation(struct btrfs_root *root);
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 504 bytes --]