* [PATCH] btrfs: Remove obsolete function declaration
@ 2018-03-21 7:03 Nikolay Borisov
2018-03-21 7:16 ` Qu Wenruo
2018-03-21 11:07 ` David Sterba
0 siblings, 2 replies; 6+ messages in thread
From: Nikolay Borisov @ 2018-03-21 7:03 UTC (permalink / raw)
To: dsterba; +Cc: wqu, linux-btrfs, Nikolay Borisov
This function was removed in 24bc2843edd5 ("btrfs:
Refactor __get_raid_index() to btrfs_bg_flags_to_raid_index()") what
remains is a defunct declaration. Remove it.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
David,
This is a fixlet to the aforementioned patch which is only in your misc-next,
I'd suggest just squash this fixlet into the original one.
fs/btrfs/ctree.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index fbe51edb9cac..03be51d77357 100644
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -2801,7 +2801,6 @@ int btrfs_trim_fs(struct btrfs_fs_info *fs_info, struct fstrim_range *range);
int btrfs_init_space_info(struct btrfs_fs_info *fs_info);
int btrfs_delayed_refs_qgroup_accounting(struct btrfs_trans_handle *trans,
struct btrfs_fs_info *fs_info);
-int __get_raid_index(u64 flags);
int btrfs_start_write_no_snapshotting(struct btrfs_root *root);
void btrfs_end_write_no_snapshotting(struct btrfs_root *root);
void btrfs_wait_for_snapshot_creation(struct btrfs_root *root);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] btrfs: Remove obsolete function declaration
2018-03-21 7:03 [PATCH] btrfs: Remove obsolete function declaration Nikolay Borisov
@ 2018-03-21 7:16 ` Qu Wenruo
2018-03-21 7:38 ` Nikolay Borisov
2018-03-21 10:09 ` David Sterba
2018-03-21 11:07 ` David Sterba
1 sibling, 2 replies; 6+ messages in thread
From: Qu Wenruo @ 2018-03-21 7:16 UTC (permalink / raw)
To: Nikolay Borisov, dsterba; +Cc: linux-btrfs
[-- Attachment #1.1: Type: text/plain, Size: 1443 bytes --]
On 2018年03月21日 15:03, Nikolay Borisov wrote:
> This function was removed in 24bc2843edd5 ("btrfs:
> Refactor __get_raid_index() to btrfs_bg_flags_to_raid_index()") what
> remains is a defunct declaration. Remove it.
Nice find, thanks for get this.
But strangely, I just fetched David's repo, but didn't find that commit
hash anywhere.
I'm fetching from git.kernel.org repo, or is that repo only updated when
pushing to Linus?
Thanks,
Qu
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
> David,
>
> This is a fixlet to the aforementioned patch which is only in your misc-next,
> I'd suggest just squash this fixlet into the original one.
>
> fs/btrfs/ctree.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
> index fbe51edb9cac..03be51d77357 100644
> --- a/fs/btrfs/ctree.h
> +++ b/fs/btrfs/ctree.h
> @@ -2801,7 +2801,6 @@ int btrfs_trim_fs(struct btrfs_fs_info *fs_info, struct fstrim_range *range);
> int btrfs_init_space_info(struct btrfs_fs_info *fs_info);
> int btrfs_delayed_refs_qgroup_accounting(struct btrfs_trans_handle *trans,
> struct btrfs_fs_info *fs_info);
> -int __get_raid_index(u64 flags);
> int btrfs_start_write_no_snapshotting(struct btrfs_root *root);
> void btrfs_end_write_no_snapshotting(struct btrfs_root *root);
> void btrfs_wait_for_snapshot_creation(struct btrfs_root *root);
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 504 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] btrfs: Remove obsolete function declaration
2018-03-21 7:16 ` Qu Wenruo
@ 2018-03-21 7:38 ` Nikolay Borisov
2018-03-21 7:45 ` Qu Wenruo
2018-03-21 10:09 ` David Sterba
1 sibling, 1 reply; 6+ messages in thread
From: Nikolay Borisov @ 2018-03-21 7:38 UTC (permalink / raw)
To: Qu Wenruo, dsterba; +Cc: linux-btrfs
On 21.03.2018 09:16, Qu Wenruo wrote:
>
>
> On 2018年03月21日 15:03, Nikolay Borisov wrote:
>> This function was removed in 24bc2843edd5 ("btrfs:
>> Refactor __get_raid_index() to btrfs_bg_flags_to_raid_index()") what
>> remains is a defunct declaration. Remove it.
>
> Nice find, thanks for get this.
>
>
> But strangely, I just fetched David's repo, but didn't find that commit
> hash anywhere.
>
> I'm fetching from git.kernel.org repo, or is that repo only updated when
> pushing to Linus?
It's update only when david pushes and preps the pull reqs. I base all
my development on his misc-next branch on github.
>
> Thanks,
> Qu
>
>>
>> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
>> ---
>> David,
>>
>> This is a fixlet to the aforementioned patch which is only in your misc-next,
>> I'd suggest just squash this fixlet into the original one.
>>
>> fs/btrfs/ctree.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
>> index fbe51edb9cac..03be51d77357 100644
>> --- a/fs/btrfs/ctree.h
>> +++ b/fs/btrfs/ctree.h
>> @@ -2801,7 +2801,6 @@ int btrfs_trim_fs(struct btrfs_fs_info *fs_info, struct fstrim_range *range);
>> int btrfs_init_space_info(struct btrfs_fs_info *fs_info);
>> int btrfs_delayed_refs_qgroup_accounting(struct btrfs_trans_handle *trans,
>> struct btrfs_fs_info *fs_info);
>> -int __get_raid_index(u64 flags);
>> int btrfs_start_write_no_snapshotting(struct btrfs_root *root);
>> void btrfs_end_write_no_snapshotting(struct btrfs_root *root);
>> void btrfs_wait_for_snapshot_creation(struct btrfs_root *root);
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] btrfs: Remove obsolete function declaration
2018-03-21 7:38 ` Nikolay Borisov
@ 2018-03-21 7:45 ` Qu Wenruo
0 siblings, 0 replies; 6+ messages in thread
From: Qu Wenruo @ 2018-03-21 7:45 UTC (permalink / raw)
To: Nikolay Borisov, Qu Wenruo, dsterba; +Cc: linux-btrfs
[-- Attachment #1.1: Type: text/plain, Size: 2014 bytes --]
On 2018年03月21日 15:38, Nikolay Borisov wrote:
>
>
> On 21.03.2018 09:16, Qu Wenruo wrote:
>>
>>
>> On 2018年03月21日 15:03, Nikolay Borisov wrote:
>>> This function was removed in 24bc2843edd5 ("btrfs:
>>> Refactor __get_raid_index() to btrfs_bg_flags_to_raid_index()") what
>>> remains is a defunct declaration. Remove it.
>>
>> Nice find, thanks for get this.
>>
>>
>> But strangely, I just fetched David's repo, but didn't find that commit
>> hash anywhere.
>>
>> I'm fetching from git.kernel.org repo, or is that repo only updated when
>> pushing to Linus?
>
> It's update only when david pushes and preps the pull reqs. I base all
> my development on his misc-next branch on github.
No wonder.
Thanks,
Qu
>>
>> Thanks,
>> Qu
>>
>>>
>>> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
>>> ---
>>> David,
>>>
>>> This is a fixlet to the aforementioned patch which is only in your misc-next,
>>> I'd suggest just squash this fixlet into the original one.
>>>
>>> fs/btrfs/ctree.h | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
>>> index fbe51edb9cac..03be51d77357 100644
>>> --- a/fs/btrfs/ctree.h
>>> +++ b/fs/btrfs/ctree.h
>>> @@ -2801,7 +2801,6 @@ int btrfs_trim_fs(struct btrfs_fs_info *fs_info, struct fstrim_range *range);
>>> int btrfs_init_space_info(struct btrfs_fs_info *fs_info);
>>> int btrfs_delayed_refs_qgroup_accounting(struct btrfs_trans_handle *trans,
>>> struct btrfs_fs_info *fs_info);
>>> -int __get_raid_index(u64 flags);
>>> int btrfs_start_write_no_snapshotting(struct btrfs_root *root);
>>> void btrfs_end_write_no_snapshotting(struct btrfs_root *root);
>>> void btrfs_wait_for_snapshot_creation(struct btrfs_root *root);
>>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 520 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] btrfs: Remove obsolete function declaration
2018-03-21 7:16 ` Qu Wenruo
2018-03-21 7:38 ` Nikolay Borisov
@ 2018-03-21 10:09 ` David Sterba
1 sibling, 0 replies; 6+ messages in thread
From: David Sterba @ 2018-03-21 10:09 UTC (permalink / raw)
To: Qu Wenruo; +Cc: Nikolay Borisov, dsterba, linux-btrfs
On Wed, Mar 21, 2018 at 03:16:25PM +0800, Qu Wenruo wrote:
>
>
> On 2018年03月21日 15:03, Nikolay Borisov wrote:
> > This function was removed in 24bc2843edd5 ("btrfs:
> > Refactor __get_raid_index() to btrfs_bg_flags_to_raid_index()") what
> > remains is a defunct declaration. Remove it.
>
> Nice find, thanks for get this.
>
>
> But strangely, I just fetched David's repo, but didn't find that commit
> hash anywhere.
>
> I'm fetching from git.kernel.org repo, or is that repo only updated when
> pushing to Linus?
The workflow hasn't changed for a few months, but after the last round
of complaints and surprises where are the development patches, I've
updated the wiki page:
https://btrfs.wiki.kernel.org/index.php/Btrfs_source_repositories#Kernel_module
If there's information missing or unclear, please let me know.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] btrfs: Remove obsolete function declaration
2018-03-21 7:03 [PATCH] btrfs: Remove obsolete function declaration Nikolay Borisov
2018-03-21 7:16 ` Qu Wenruo
@ 2018-03-21 11:07 ` David Sterba
1 sibling, 0 replies; 6+ messages in thread
From: David Sterba @ 2018-03-21 11:07 UTC (permalink / raw)
To: Nikolay Borisov; +Cc: WenRuo Qu, linux-btrfs
On Wed, Mar 21, 2018 at 09:03:41AM +0200, Nikolay Borisov wrote:
> This function was removed in 24bc2843edd5 ("btrfs:
> Refactor __get_raid_index() to btrfs_bg_flags_to_raid_index()") what
> remains is a defunct declaration. Remove it.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
> David,
>
> This is a fixlet to the aforementioned patch which is only in your misc-next,
> I'd suggest just squash this fixlet into the original one.
Yes, makes sense. Done.
If that happens in the future again, sending a separate mail (not
necessarily a full blown patch with changelog etc) works fine, namely
for patches that are deep in the devel queue like that one. So, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-21 11:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-21 7:03 [PATCH] btrfs: Remove obsolete function declaration Nikolay Borisov
2018-03-21 7:16 ` Qu Wenruo
2018-03-21 7:38 ` Nikolay Borisov
2018-03-21 7:45 ` Qu Wenruo
2018-03-21 10:09 ` David Sterba
2018-03-21 11:07 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).