Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Zorro Lang <zlang@redhat.com>,
	Naohiro Aota <naohiro.aota@wdc.com>,
	 fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] generic/793: limit number of overwrites
Date: Fri, 24 Apr 2026 16:01:05 +0900	[thread overview]
Message-ID: <aesUG04ZDkcyGqQ-@shinmob> (raw)
In-Reply-To: <20260424062222.87298-1-johannes.thumshirn@wdc.com>

On Apr 24, 2026 / 08:22, Johannes Thumshirn wrote:
> Testcase generic/793 overwrites a 1GB file "number of sequential zones"
> times in order to trigger a bug in zoned BTRFS' garbage collection. But on
> scratch devices with a huge number of sequential zones (like SMR drives)
> this can cause very long runtimes.
> 
> As the testcase also limits the filesystem size to 16GB, constraint the
> number of overwrite loops to the number of sequential zones in the
> filesystem. This still guarantees that the file will be overwritten often
> enough to trigger the bug while not exploding the overall test runtime.
> 
> Reported-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Thanks for the fix. Without this fix, the testcase run for SMR drives did not
complete even after 10 hours run. I applied the patch and confrimed that the
testcase completes within 7 minutes or so.

Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>

  reply	other threads:[~2026-04-24  7:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-24  6:22 [PATCH] generic/793: limit number of overwrites Johannes Thumshirn
2026-04-24  7:01 ` Shin'ichiro Kawasaki [this message]
2026-04-24 10:58 ` Hans Holmberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aesUG04ZDkcyGqQ-@shinmob \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=fstests@vger.kernel.org \
    --cc=hch@lst.de \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=naohiro.aota@wdc.com \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox