From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] fstests: generic/362: remove the old file to reflect new mount options
Date: Tue, 26 May 2026 23:34:53 -0700 [thread overview]
Message-ID: <ahaQjYYQWcuOaRaq@infradead.org> (raw)
In-Reply-To: <20260526070055.60193-1-wqu@suse.com>
On Tue, May 26, 2026 at 04:30:55PM +0930, Qu Wenruo wrote:
> Silence is golden
> ...
> (Run 'diff -u /home/adam/xfstests/tests/generic/362.out /home/adam/xfstests/results//generic/362.out.bad' to see the entire diff)
>
> But if one has formated TEST_DEV, run test with default mount option,
> then change the mount option to "nodatasum", the test will not fail
> anymore:
> [FIX]
> Always delete the target file "$TEST_DIR/dio-append-buf-fault" before
> running dio-append-buf-fault command.
>
> So that the new target file is always newly created and will follow
> btrfs' new mount option and expose the failure for nodatasum.
I'd rather add a copy of the test that runs on the scratch device
that can control the environment. Or maybe just change the test
to use the scratch device?
next prev parent reply other threads:[~2026-05-27 6:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 7:00 [PATCH] fstests: generic/362: remove the old file to reflect new mount options Qu Wenruo
2026-05-27 6:34 ` Christoph Hellwig [this message]
2026-05-27 6:50 ` Qu Wenruo
2026-05-27 13:03 ` Christoph Hellwig
2026-05-27 21:42 ` Qu Wenruo
2026-05-29 9:02 ` Zorro Lang
2026-05-27 14:26 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahaQjYYQWcuOaRaq@infradead.org \
--to=hch@infradead.org \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox