From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sjc00mx2.hgst.com ([199.255.44.37]:22461 "EHLO sjc00mx2.hgst.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751650AbcFBN6m (ORCPT ); Thu, 2 Jun 2016 09:58:42 -0400 Date: Thu, 2 Jun 2016 09:58:13 -0400 From: Scott Talbert To: Filipe Manana CC: Yauhen Kharuzhy , Scott Talbert , "linux-btrfs@vger.kernel.org" Subject: Re: Device replace issues and disabling it until they are solved In-Reply-To: Message-ID: References: <20160602100321.GA20887@jeknote.loshitsa1.net> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII"; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Thu, 2 Jun 2016, Filipe Manana wrote: > On Thu, Jun 2, 2016 at 11:03 AM, Yauhen Kharuzhy > wrote: >> On Fri, May 27, 2016 at 10:43:47AM +0100, Filipe Manana wrote: >>>> Hi Filipe, >>> >>> Hi Scott, >>> >>>> >>>> Does your recent patch set (from May 20) address all of these issues? >>> >>> Yes. >> >> Tested, RAID5/6 still produces a plenty of 'failed to rebuild valid >> logical NNNNNN" messages after two consecutive device replaces. So, >> replace is still not usable for RAID5/6. And it is very slow in >> comparison with 'device add && balance device remove missing' sequence >> (4x slower). > > Right. There's missing code for raid5/6 I believe. I didn't care about > that, nor will in the near future at least. > The set of problems I tried to solve were generic and unrelated to any > specific raid mode. Back to your original question, then...should replace be disabled for raid5/6 until it is fixed? Scott