Re: [PATCH -v7][RFC]: mutex: implement adaptive spinning

Linus Torvalds
2009-01-10T01:34:09Z

On Sat, 10 Jan 2009, Ingo Molnar wrote:

>
> * Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> > On Sat, 10 Jan 2009, Ingo Molnar wrote:
> > >
> > > Well, it's not totally meaningless. To begin with, defining 'inline' to
> > > mean 'always inline' is a Linux kernel definition. So we already changed
> > > the behavior - in the hope of getting it right most of the time and in the
> > > hope of thus improving the kernel.
> >
> > Umm. No we didn't. We've never changed it. It was "always inline" back in
>
> s/changed the behavior/overrode the behavior

The point is, as far as the kenrel has been concerned, "inline" has always
meant the same thing. Not just for the last few weeks, but for the last 18
_years_. It's always meant "always inline".

> But i'd definitely argue that the Linux kernel definition of 'inline' was
> always more consistent than GCC's. That was rather easy as well: it doesnt
> get any more clear-cut than 'always inline'.

Exactly. And I argue that we shouldn't change it.

If we have too many "inline"s, and if gcc inlines for us _anyway_, then
the answer is not to change the meaning of "inline", but simply say "ok,
we have too many inlines. Let's remove the ones we don't care about".

> I think it is axiomatic that improving the kernel means changing it -
> sometimes that means changing deep details. (And if you see us ignoring
> complaints, let us know, it must not happen.)

And I'm agreeing with you.

What I'm _not_ agreeing with is how you want to change the semantics of
something we've had for 18 years.

YOU are the one who want to make "inline" mean "maybe". I'm against it.
I'm against it because it makes no sense. It's not what we've ever done.

Linus