Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christoph Hellwig <hch@infradead.org>, Qu Wenruo <wqu@suse.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: use IOMAP_DIO_BOUNCE flag for direct reads
Date: Mon, 31 Aug 2026 01:09:30 -0700	[thread overview]
Message-ID: <apU2ugNeGspvr75y@infradead.org> (raw)
In-Reply-To: <74188ab7-96d7-4536-997f-926a5a845f79@gmx.com>

On Mon, Aug 31, 2026 at 05:01:21PM +0930, Qu Wenruo wrote:
> However it only shows up in lore, but not in my inbox at all, and I have no
> idea why.
> 
> And lore is never a good way to review patches, nor easy to reply.

I got it brack through all the usual lists, so this must be some kind
of filtering on your side.

> > For one this removes the read-side IOMAP_DIO_BOUNCE support you are
> > using here, because it had problems.  The alternative is iomap-based
> > and better at building large, aligned read bios which matter for HDD.
> > It also introduces the concept of lazy bouncing where it only bounce
> > buffers after a checksum failure happens by default, which means you
> > only pay an overhead for misbehaving applications.
> 
> In that case I'm afraid btrfs may need some way to integrate the checksum
> handling into iomap.
> As the btrfs has a very internal handling for repairing each block.

The only iomap path is the bounce buffering, the checksum handling is
still left to the file systems.  The code will probably need some
minor tweaks for btrfs, like passing in a bio_set to use for the clones,
but it shouldn't be too bad.


      parent reply	other threads:[~2026-08-31  8:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28  9:28 [PATCH] btrfs: use IOMAP_DIO_BOUNCE flag for direct reads Qu Wenruo
2026-08-28 13:26 ` Wang Yugui
2026-08-31  7:15 ` Christoph Hellwig
2026-08-31  7:31   ` Qu Wenruo
2026-08-31  7:54     ` Johannes Thumshirn
2026-08-31  8:09     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apU2ugNeGspvr75y@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox