From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
To: Wang Yugui <wangyugui@e16-tech.com>
Cc: linux-btrfs@vger.kernel.org, Naohiro Aota <naohiro.aota@wdc.com>
Subject: Re: [PATCH v2 1/4] btrfs: zoned: only change active zone counter on successful (de)activation
Date: Fri, 2 Oct 2026 18:28:20 +0200 [thread overview]
Message-ID: <ar_bh6Ju5kSXYn3n@mayhem.fritz.box> (raw)
In-Reply-To: <20261002233856.C191.409509F4@e16-tech.com>
On Fri, Oct 02, 2026 at 11:38:57PM +0800, Wang Yugui wrote:
> > @@ -2411,6 +2420,7 @@ bool btrfs_zone_activate(struct btrfs_block_group *block_group)
> > u64 physical;
> > const bool is_data = (block_group->flags & BTRFS_BLOCK_GROUP_DATA);
> > bool ret;
> > + bool new;
>
> 'new' is not a good var name because it is a keyword in C++/Java.
>
> 'is_new' just like above 'is_data' maybe a better var name.
But this is C not C++ or Java.
next prev parent reply other threads:[~2026-10-02 16:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 7:37 [PATCH v2 0/4] btrfs: zoned: LLM inspired fixes Johannes Thumshirn
2026-10-02 7:37 ` [PATCH v2 1/4] btrfs: zoned: only change active zone counter on successful (de)activation Johannes Thumshirn
2026-10-02 15:38 ` Wang Yugui
2026-10-02 16:28 ` Johannes Thumshirn [this message]
2026-10-02 7:37 ` [PATCH v2 2/4] btrfs: zoned: fix possible UAF in wait_eb_writebacks Johannes Thumshirn
2026-10-02 7:37 ` [PATCH v2 3/4] btrfs: zoned: requeue block group if zone reset bails out Johannes Thumshirn
2026-10-02 7:37 ` [PATCH v2 4/4] btrfs: zoned: avoid underflow of bytes_zone_unusable Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ar_bh6Ju5kSXYn3n@mayhem.fritz.box \
--to=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=wangyugui@e16-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox