From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH] btrfs: props: validate property values loaded from disk
Date: Tue, 17 Nov 2026 07:19:09 +0100 [thread overview]
Message-ID: <avvxsrVakxTIcs9g@neo> (raw)
In-Reply-To: <27eb729ab79e98927812e0e1df9e699716df6036.1794522787.git.wqu@suse.com>
On Fri, Nov 13, 2026 at 09:03:10AM +1030, Qu Wenruo wrote:
> This may cause a behavior change: validate also rejects compression on
> inodes that cannot be compressed (NODATACOW or NODATASUM). Such an inode
> with an existing compression xattr, e.g. one set before "chattr +C" on
> an empty file, used to get BTRFS_INODE_COMPRESS applied on load. Now the
> property is skipped with a warning.
Which I think is the correct thing to do either way, so:
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
prev parent reply other threads:[~2026-11-17 6:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 22:33 [PATCH] btrfs: props: validate property values loaded from disk Qu Wenruo
2026-11-17 6:19 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avvxsrVakxTIcs9g@neo \
--to=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox