From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/4] factor __btrfs_open_devices()
Date: Thu, 16 Nov 2017 12:08:57 +0800 [thread overview]
Message-ID: <b036a131-4557-840e-d2f6-0dcc266646db@oracle.com> (raw)
In-Reply-To: <20171115170355.GW28899@twin.jikos.cz>
On 11/16/2017 01:03 AM, David Sterba wrote:
> On Thu, Nov 09, 2017 at 11:45:22PM +0800, Anand Jain wrote:
>> This is in preparation to help bring the missing device back to the
>> alloc list dynamically. As of now if we run 'btrfs dev scan </dev/missing>'
>> on a mounted FS, nothing happens, there is no code which handles this
>> condition. So the idea is to fix it by running through the device open
>> process for the reappeared missing device.
>>
>> So this patch separates device open steps into a separate function so that
>> it can be called for a device, instead of for all the devices in the
>> dev_list. As this function is in the critical mount section, and to show
>> the src code changes as clearly as possible, I have created 4 no-functional
>> changes patches, which can be merged together if needed.
>
> The splitting is fine, I've only merged 2 and 4 to one, but otherwise
> it's clear from each patch if there are no functional changes. 1,3,2+4
> added to next, thanks.
Thanks indeed. (git-diff showed changes which didn't make sense,
I had to split, merge is fine).
Thanks, Anand
prev parent reply other threads:[~2017-11-16 4:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 15:45 [PATCH 0/4] factor __btrfs_open_devices() Anand Jain
2017-11-09 15:45 ` [PATCH 1/4] btrfs: set fs_devices->seed directly Anand Jain
2017-11-09 15:45 ` [PATCH 2/4] btrfs: let variable required be declared inside the loop Anand Jain
2017-11-09 15:53 ` Nikolay Borisov
2017-11-15 17:01 ` David Sterba
2017-11-09 15:45 ` [PATCH 3/4] btrfs: move check for device generation to the last Anand Jain
2017-11-09 15:45 ` [PATCH 4/4] btrfs: factor __btrfs_open_devices() to create btrfs_open_one_device() Anand Jain
2017-11-27 6:47 ` Lakshmipathi.G
2017-11-27 11:47 ` Anand Jain
2017-11-29 16:02 ` Lakshmipathi.G
2017-11-27 14:00 ` [PATCH] btrfs: ignore return from btrfs_open_one_device() Anand Jain
2017-11-15 17:03 ` [PATCH 0/4] factor __btrfs_open_devices() David Sterba
2017-11-16 4:08 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b036a131-4557-840e-d2f6-0dcc266646db@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).