linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/1] btrfs: log, when replace, is canceled by the user
Date: Tue, 13 Feb 2018 11:50:30 +0800	[thread overview]
Message-ID: <b28d1c6e-001c-58a9-4687-48103cbaaabc@oracle.com> (raw)
In-Reply-To: <55cc08af-67f5-64c3-d5df-0b41d4c2cf57@gmx.com>



>> +
>> +	btrfs_info(fs_info, "dev_replace from %s (devid %llu) to %s canceled",
>> +		   btrfs_dev_name(src_device), src_device->devid,
>> +		   rcu_str_deref(tgt_device->name));
> 
> The behavior is quite good.
> 
> Although I'm wondering why for @src_device we use btrfs_dev_name() but
> rcu_str_deref() for @tgt_device?

   Thanks for the comments.
   My bad. In fact, I must use btrfs_dev_name() for tgt_device since
   the tgt_device can be missing (-o degraded) when the user decides
   to cancel.

Thanks, Anand

  reply	other threads:[~2018-02-13  3:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 15:36 [PATCH 1/1] btrfs: log, when replace, is canceled by the user Anand Jain
2018-02-13  1:47 ` Qu Wenruo
2018-02-13  3:50   ` Anand Jain [this message]
2018-02-13  3:53 ` [PATCH v2] " Anand Jain
2018-02-13  9:05   ` Qu Wenruo
2018-02-13  9:08     ` Nikolay Borisov
2018-02-13  9:10       ` Qu Wenruo
2018-02-13 17:04   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b28d1c6e-001c-58a9-4687-48103cbaaabc@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).