From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v5.3 07/11] btrfs: extent_io: Handle error better in extent_write_locked_range()
Date: Thu, 21 Mar 2019 21:45:29 +0800 [thread overview]
Message-ID: <b2c6a1db-db0c-f394-dff1-f4c0ea57b3e5@gmx.com> (raw)
In-Reply-To: <20190321131920.GB26179@twin.jikos.cz>
[-- Attachment #1.1: Type: text/plain, Size: 1094 bytes --]
On 2019/3/21 下午9:19, David Sterba wrote:
> On Wed, Mar 20, 2019 at 02:27:45PM +0800, Qu Wenruo wrote:
>> Do proper cleanup if we hit any error in extent_write_locked_range(),
>> and check the return value of flush_write_bio().
>
> Yes that's what the code does, but the changelog should explain why this
> is correct. Same for "btrfs: extent_io: Handle error better in
> extent_writepages()". You do that in other patches, why not in this one
> too?
My bad, I thought the patch implementing end_write_bio() explains why
the cleanup function is doing the same work as previous
flush_write_bio(), but skipping the bio submitting.
So I skipped the reason why calling end_write_bio() here is enough for
the error case.
> If the reason is same for several patches, then copy it, eg. btrfs:
> "extent_io: Handle errors better in btree_write_cache_pages()" is ok.
>
> But don't resend, I'll fix it here as I made some other fixups to
> changelogs and am finishing the whole series.
Thank you for the effort and sorry for the inconvenience.
Thanks,
Qu
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-03-21 13:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 6:27 [PATCH v5.3 00/11] btrfs: tree-checker: Write time tree checker Qu Wenruo
2019-03-20 6:27 ` [PATCH v5.3 01/11] btrfs: Always output error message when key/level verification fails Qu Wenruo
2019-03-20 6:27 ` [PATCH v5.3 02/11] btrfs: disk-io: Show the timing of corrupted tree block explicitly Qu Wenruo
2019-03-29 14:11 ` David Sterba
2019-03-29 14:18 ` Qu Wenruo
2019-03-20 6:27 ` [PATCH v5.3 03/11] btrfs: extent_io: Move the BUG_ON() in flush_write_bio() one level up Qu Wenruo
2019-03-20 19:39 ` David Sterba
2019-03-20 6:27 ` [PATCH v5.3 04/11] btrfs: extent_io: Handle error better in extent_write_full_page() Qu Wenruo
2019-03-20 6:27 ` [PATCH v5.3 05/11] btrfs: extent_io: Handle error better in btree_write_cache_pages() Qu Wenruo
2019-03-20 6:27 ` [PATCH v5.3 06/11] btrfs: extent_io: Kill the dead branch in extent_write_cache_pages() Qu Wenruo
2019-03-20 6:27 ` [PATCH v5.3 07/11] btrfs: extent_io: Handle error better in extent_write_locked_range() Qu Wenruo
2019-03-21 13:19 ` David Sterba
2019-03-21 13:45 ` Qu Wenruo [this message]
2019-03-20 6:27 ` [PATCH v5.3 08/11] btrfs: extent_io: Kill the BUG_ON() in lock_extent_buffer_for_io() Qu Wenruo
2019-03-21 13:30 ` David Sterba
2019-03-20 6:27 ` [PATCH v5.3 09/11] btrfs: extent_io: Kill the BUG_ON() in extent_write_cache_pages() Qu Wenruo
2019-03-21 14:14 ` David Sterba
2019-03-20 6:27 ` [PATCH v5.3 10/11] btrfs: extent_io: Handle error better in extent_writepages() Qu Wenruo
2019-03-20 6:27 ` [PATCH v5.3 11/11] btrfs: Do mandatory tree block check before submitting bio Qu Wenruo
2019-04-03 9:07 ` Qu Wenruo
2019-03-21 14:34 ` [PATCH v5.3 00/11] btrfs: tree-checker: Write time tree checker David Sterba
2019-03-21 23:56 ` Qu Wenruo
2019-03-22 17:52 ` David Sterba
2019-03-25 4:32 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2c6a1db-db0c-f394-dff1-f4c0ea57b3e5@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).