From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4656C83005 for ; Wed, 7 Jun 2023 13:06:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239480AbjFGNGs (ORCPT ); Wed, 7 Jun 2023 09:06:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233152AbjFGNGr (ORCPT ); Wed, 7 Jun 2023 09:06:47 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7459EA6; Wed, 7 Jun 2023 06:06:46 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 22F7E1FDAA; Wed, 7 Jun 2023 13:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686143205; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fC4lpDijC8/t0vyixr0uR4OHm5CdZgOC/YH8pyULvJ4=; b=mT5pfBh8FGWafegO1axUM/e21dR6I+ZhfqW23d13QQmoj30i1cA9GVd/xtX2fFGaqo6P/M m4cvhFdSUE5o9QWKqRwwYbc75DKY8YjBrGlR1faw185yVzUx7FIl7F2t/sHdAbApNvSqhV X0FYqppckqUmHdSoV6cifqAF8NlvJNY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686143205; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fC4lpDijC8/t0vyixr0uR4OHm5CdZgOC/YH8pyULvJ4=; b=nZ47Mjj6nSf/Y6gwFwOUit9Nn2Kj+3xzIzwQJMKriV78QvCa0W+0AMfV+aegjAda09qIxE 98WCidmidDjEFgDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D57681346D; Wed, 7 Jun 2023 13:06:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3RNvM+SAgGQGXAAAMHmgww (envelope-from ); Wed, 07 Jun 2023 13:06:44 +0000 Message-ID: Date: Wed, 7 Jun 2023 15:06:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 22/31] nvme: replace the fmode_t argument to the nvme ioctl handlers with a simple bool Content-Language: en-US To: Christoph Hellwig , Jens Axboe Cc: Richard Weinberger , Josef Bacik , "Md. Haris Iqbal" , Jack Wang , Phillip Potter , Coly Li , Miquel Raynal , Vignesh Raghavendra , "Martin K. Petersen" , Chris Mason , David Sterba , Alexander Viro , Christian Brauner , "Rafael J. Wysocki" , Pavel Machek , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-um@lists.infradead.org, linux-scsi@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nilfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-pm@vger.kernel.org References: <20230606073950.225178-1-hch@lst.de> <20230606073950.225178-23-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230606073950.225178-23-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 6/6/23 09:39, Christoph Hellwig wrote: > Instead of passing a fmode_t and only checking it fo0r FMODE_WRITE, pass > a bool open_for_write to prepare for callers that won't have the fmode_t. > > Signed-off-by: Christoph Hellwig > --- > drivers/nvme/host/ioctl.c | 62 +++++++++++++++++++++------------------ > 1 file changed, 34 insertions(+), 28 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes