From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60D35C33CA2 for ; Fri, 10 Jan 2020 09:14:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 333902072E for ; Fri, 10 Jan 2020 09:14:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ZAzDjXx0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726823AbgAJJOX (ORCPT ); Fri, 10 Jan 2020 04:14:23 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:48040 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726641AbgAJJOX (ORCPT ); Fri, 10 Jan 2020 04:14:23 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00A9DGPR004818; Fri, 10 Jan 2020 09:14:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=BI76oBg7CTKePu5KfZhXAvNSxNcFF8BfPHLFY2Kwy/w=; b=ZAzDjXx0RkaUfnYhaiBsY340re+SflUk+hwi5wGuPxwATamYqg8PIoIZFKP7SNQc4xTl 0enWiSUUTZjpILVfnNNmk7sepsa2H6UUNCAI10WlrVJRKQoJwSHEKtHldYgoSEaAz4PP Yfz4ahKw1DyFgsB2/+Yq8NzReZFu+Lsyxb8HEudqCY0JMPRmO1X2J9E6k2fySZKHUPNH ZnWcNxkxcVEPZhZGkSHUHU5narnBVfB00g5Il58tKybtp7rANKjTdR2+wp0CoXLgZHEb hlutdAkUFohrkCJ1aqSWAYN2eOkmLax3Sf4tUqQYQloSZ3ObrNJrsvL+Mh5qoCJnyF4v /w== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 2xajnqgq7c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 10 Jan 2020 09:14:16 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00A9E53v031338; Fri, 10 Jan 2020 09:14:16 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 2xenn8y3wh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 10 Jan 2020 09:14:13 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 00A9De7d003418; Fri, 10 Jan 2020 09:13:40 GMT Received: from [10.190.130.61] (/192.188.170.109) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 10 Jan 2020 01:13:40 -0800 Subject: Re: [PATCH] btrfs: Fix error code in btrfs_sysfs_add_mounted() To: Dan Carpenter , Chris Mason , Dennis Zhou Cc: Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20200110055126.4rhhfsotll6puma7@kili.mountain> From: Anand Jain Message-ID: Date: Fri, 10 Jan 2020 17:13:35 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200110055126.4rhhfsotll6puma7@kili.mountain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9495 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001100078 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9495 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001100078 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 10/1/20 1:51 PM, Dan Carpenter wrote: > The error code wasn't set on this error path. > > Fixes: e12ebce8a4a8 ("btrfs: sysfs: make UUID/debug have its own kobject") > Signed-off-by: Dan Carpenter > --- > fs/btrfs/sysfs.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c > index 58486229be95..55e4ed1af29c 100644 > --- a/fs/btrfs/sysfs.c > +++ b/fs/btrfs/sysfs.c > @@ -1288,8 +1288,10 @@ int btrfs_sysfs_add_mounted(struct btrfs_fs_info *fs_info) > > #ifdef CONFIG_BTRFS_DEBUG > fs_info->debug_kobj = kobject_create_and_add("debug", fsid_kobj); > - if (!fs_info->debug_kobj) > + if (!fs_info->debug_kobj) { > + error = -ENOMEM; uh-oh right. Reviewed-by: Anand Jain Thanks, Anand > goto failure; > + } > > error = sysfs_create_files(fs_info->debug_kobj, btrfs_debug_mount_attrs); > if (error) >