From: Anand Jain <anand.jain@oracle.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: manage thread_pool mount option as %u
Date: Tue, 13 Feb 2018 23:18:41 +0800 [thread overview]
Message-ID: <b72463c0-6d27-5fe7-b790-4d6c3b5dfca0@oracle.com> (raw)
In-Reply-To: <12714050-aece-8bfd-2e83-ef5da4590c81@suse.com>
>> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
>> index 02c7766e6849..8112619cac95 100644
>> --- a/fs/btrfs/super.c
>> +++ b/fs/btrfs/super.c
>> @@ -346,7 +346,7 @@ static const match_table_t tokens = {
>> {Opt_barrier, "barrier"},
>> {Opt_max_inline, "max_inline=%u"},
>> {Opt_alloc_start, "alloc_start=%s"},
>> - {Opt_thread_pool, "thread_pool=%d"},
>> + {Opt_thread_pool, "thread_pool=%u"},
>> {Opt_compress, "compress"},
>> {Opt_compress_type, "compress=%s"},
>> {Opt_compress_force, "compress-force"},
>> @@ -596,12 +596,11 @@ int btrfs_parse_options(struct btrfs_fs_info *info, char *options,
>> ret = match_int(&args[0], &intarg);
>> if (ret) {
>> goto out;
>> - } else if (intarg > 0) {
>> - info->thread_pool_size = intarg;
>> - } else {
>> + } else if (intarg == 0) {
>
> One thing I'm worried about is the fact that match_int parses a signed
> int. So If someone pases -1 then it would be parsed to -1 but when you
> set it to thread_pool_size the actual value is going to be the 2's
> complement of the value i.e. a very large number. So a check for intarg
> < 0 is required to avoid that. Same applies to your other patches
That's not true. When -o thread_pool=-1 is passed it would fail
to match to any token. And same applies to other patches too.
Thanks, Anand
next prev parent reply other threads:[~2018-02-13 15:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 9:50 [PATCH] btrfs: manage thread_pool mount option as %u Anand Jain
2018-02-13 9:50 ` [PATCH] btrfs: manage subvolid " Anand Jain
2018-02-13 16:10 ` David Sterba
2018-02-14 17:11 ` [PATCH v2] btrfs: verify subvolid mount parameter Anand Jain
2018-02-23 22:08 ` David Sterba
2018-02-14 17:15 ` [PATCH] btrfs: manage subvolid mount option as %u Anand Jain
2018-02-13 9:50 ` [PATCH] btrfs: manage metadata_ratio " Anand Jain
2018-02-13 9:50 ` [PATCH] btrfs: manage check_int_print_mask " Anand Jain
2018-02-13 9:50 ` [PATCH] btrfs: manage commit " Anand Jain
2018-02-13 9:50 ` [PATCH] btrfs: add a comment to mark the deprecated mount option Anand Jain
2018-02-13 9:50 ` [PATCH] btrfs: fix bare unsigned declarations Anand Jain
2018-02-13 16:58 ` David Sterba
2018-02-14 17:13 ` [PATCH v2] " Anand Jain
2018-02-23 22:12 ` David Sterba
2018-02-26 8:46 ` [PATCH v3] " Anand Jain
2018-03-07 16:07 ` David Sterba
2018-02-13 14:26 ` [PATCH] btrfs: manage thread_pool mount option as %u Nikolay Borisov
2018-02-13 15:18 ` Anand Jain [this message]
2018-02-13 15:34 ` Nikolay Borisov
2018-02-13 15:58 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b72463c0-6d27-5fe7-b790-4d6c3b5dfca0@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).