Re: btrfs-progs: RAID1C3/C4 missing some info in btrfs_raid_array

David Sterba
2020-03-26T17:37:13Z

On Thu, Mar 26, 2020 at 09:09:41AM +0800, Qu Wenruo wrote:
> On 2020/3/26 上午2:57, Goffredo Baroncelli wrote:
> >     [BTRFS_RAID_RAID1C4] = {
> >         .sub_stripes    = 1,
> >         .dev_stripes    = 1,
> >         .devs_max    = 4,
> >         .devs_min    = 4,
> >         .tolerated_failures = 3,
> >         .devs_increment    = 4,
> >         .ncopies    = 4,
> >     },
> >     [BTRFS_RAID_DUP] = {
> > [...]
> >
> > As you can see the items BTRFS_RAID_RAID1C3 and BTRFS_RAID_RAID1C4,
> > missed of the fields '.raid_name' and '.bg_flag';
> > if you look at BTRFS_RAID_RAID1 item, it has both the fields filled with
> > "raid1" and "BTRFS_BLOCK_GROUP_RAID1".
>
> Oh, you're right.
>
> AFAIK there is no special reason not to add these members.

Right, I forgot to add them back then.