From: fdmanana@kernel.org
To: fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org, Filipe Manana <fdmanana@suse.com>
Subject: [PATCH 03/10] btrfs/028: removed redundant sync and scratch filesystem unmount
Date: Wed, 27 Mar 2024 17:11:37 +0000 [thread overview]
Message-ID: <b8c6456cf2e61309ca5347c403c96feb876da48b.1711558345.git.fdmanana@suse.com> (raw)
In-Reply-To: <cover.1711558345.git.fdmanana@suse.com>
From: Filipe Manana <fdmanana@suse.com>
There's no need to have an explicit scratch filesystem sync and unmount
at the of the test, as the fstests framework automatically unmounts the
filesystem and the unmount naturally syncs any data and metadata.
So remove them and update the comment to be more clear.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
tests/btrfs/028 | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/tests/btrfs/028 b/tests/btrfs/028
index 8fbe8887..0c96b2fe 100755
--- a/tests/btrfs/028
+++ b/tests/btrfs/028
@@ -48,11 +48,8 @@ kill $fsstress_pid &> /dev/null
wait $fsstress_pid &> /dev/null
_btrfs_kill_stress_balance_pid $balance_pid
-_run_btrfs_util_prog filesystem sync $SCRATCH_MNT
-
-_scratch_unmount
-
-# qgroup will be checked at _check_scratch_fs() by fstest.
+# The qgroups accounting will be checked by 'btrfs check' (fsck) after the
+# fstests framework unmounts the filesystem.
echo "Silence is golden"
status=0
--
2.43.0
next prev parent reply other threads:[~2024-03-27 17:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 17:11 [PATCH 00/10] fstests/btrfs: fixes for tests btrfs/06[0-9] and btrfs/07[0-4] fdmanana
2024-03-27 17:11 ` [PATCH 01/10] btrfs: add helper to kill background process running _btrfs_stress_balance fdmanana
2024-03-28 8:16 ` Anand Jain
2024-03-28 9:21 ` Filipe Manana
2024-03-27 17:11 ` [PATCH 02/10] btrfs/028: use the helper _btrfs_kill_stress_balance_pid fdmanana
2024-03-28 8:41 ` Anand Jain
2024-03-28 9:25 ` Filipe Manana
2024-03-27 17:11 ` fdmanana [this message]
2024-03-27 17:11 ` [PATCH 04/10] btrfs: add helper to kill background process running _btrfs_stress_scrub fdmanana
2024-03-28 8:41 ` Anand Jain
2024-03-28 9:27 ` Filipe Manana
2024-03-27 17:11 ` [PATCH 05/10] btrfs: add helper to kill background process running _btrfs_stress_defrag fdmanana
2024-03-28 9:18 ` Anand Jain
2024-03-28 9:32 ` Filipe Manana
2024-03-27 17:11 ` [PATCH 06/10] btrfs: add helper to kill background process running _btrfs_stress_remount_compress fdmanana
2024-03-28 9:24 ` Anand Jain
2024-03-28 11:46 ` Anand Jain
2024-03-28 12:03 ` Filipe Manana
2024-03-28 12:50 ` Anand Jain
2024-03-27 17:11 ` [PATCH 07/10] btrfs: add helper to kill background process running _btrfs_stress_replace fdmanana
2024-03-28 9:35 ` Anand Jain
2024-03-27 17:11 ` [PATCH 08/10] btrfs: add helper to stop background process running _btrfs_stress_subvolume fdmanana
2024-03-28 9:36 ` Anand Jain
2024-03-27 17:11 ` [PATCH 09/10] btrfs: remove stop file early at _btrfs_stress_subvolume fdmanana
2024-03-28 9:38 ` Anand Jain
2024-03-27 17:11 ` [PATCH 10/10] btrfs/06[0-9]..07[0-4]: kill all background tasks when test is killed/interrupted fdmanana
2024-03-28 9:48 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8c6456cf2e61309ca5347c403c96feb876da48b.1711558345.git.fdmanana@suse.com \
--to=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox