Re: [PATCH 0/4] btrfs-progs: fix the filename sanitization of btrfs-image

[Qu Wenruo <wqu@suse.com>]

Ping?

Any update on this?

Thanks,
Qu

在 2024/7/8 14:44, Qu Wenruo 写道:
> There are several bugs in btrfs-image filename sanitization:
> 
> - Ensured kernel path resolution bug
>    Since during path resolution btrfs uses hash to find the child inode,
>    with garbage filled DIR_ITEMs, it's definitely unable to properly
>    resolve the path.
> 
>    A warning is added to the man page by the first patch.
> 
> - Only the last item got properly sanitized
>    All the remaining INODE_REF/DIR_INDEX/DIR_ITEM are not sanitized at
>    all.
> 
>    This is fixed by the second patch.
> 
> - Sanitized filename contains non-ASCII chars
>    This is fixed by the third patch.
> 
> 
> Finally a new test case is introduced to verify the filename
> sanitization behavior of btrfs-image.
> 
> Qu Wenruo (4):
>    btrfs-progs: add warning for -s option of btrfs-image
>    btrfs-progs: image: fix the bug that filename sanitization not working
>    btrfs-progs: fix rand_range()
>    btrfs-progs: misc-tests: add a test case for filename sanitization
> 
>   Documentation/btrfs-image.rst               | 17 ++++++-----
>   common/utils.c                              | 10 +++----
>   image/sanitize.c                            |  8 ++++-
>   tests/misc-tests/065-image-filename/test.sh | 33 +++++++++++++++++++++
>   4 files changed, 55 insertions(+), 13 deletions(-)
>   create mode 100755 tests/misc-tests/065-image-filename/test.sh
> 
> --
> 2.45.2
> 
>