From: Jeff Mahoney <jeffm@suse.com>
To: dsterba@suse.cz, Btrfs Development List <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] btrfs: prefix fsid to all trace events
Date: Mon, 13 Jun 2016 16:19:12 -0400 [thread overview]
Message-ID: <b9e6442b-a75b-6e65-d280-f1624feed4d7@suse.com> (raw)
In-Reply-To: <20160613154814.GC6205@twin.jikos.cz>
[-- Attachment #1.1: Type: text/plain, Size: 850 bytes --]
On 6/13/16 11:48 AM, David Sterba wrote:
> On Thu, Jun 09, 2016 at 07:48:01PM -0400, jeffm@suse.com wrote:
>> +#define TP_printk_btrfs(fmt, args...) \
>> + TP_printk("%pU: " fmt, __entry->fsid, args)
>
> So it's identified by the UUID. As there's no previous format of the
> filesystem identifier (unlike the syslog messages), I'm ok with using
> the UUID.
Buried in the patch is actually the single use of a previous format for
trace events that I've converted to use the macros. It's the
btrfs_space_reservation that Josef added in 2012[1].
I wouldn't have minded a shorter identifier but given how prevalent its
usage is internal to the FS, its exported interfaces, and tools
surrounding it, it seems like it's the only real choice.
-Jeff
[1] 8c2a3ca20f6 (Btrfs: space leak tracepoints)
--
Jeff Mahoney
SUSE Labs
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 881 bytes --]
prev parent reply other threads:[~2016-06-13 20:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 23:48 [PATCH 1/2] btrfs: plumb fs_info into btrfs_work jeffm
2016-06-09 23:48 ` [PATCH 2/2] btrfs: prefix fsid to all trace events jeffm
2016-06-10 16:23 ` Liu Bo
2016-06-11 13:41 ` Chris Mason
2016-06-13 15:48 ` David Sterba
2016-06-13 20:19 ` Jeff Mahoney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9e6442b-a75b-6e65-d280-f1624feed4d7@suse.com \
--to=jeffm@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).