From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Eric Biggers <ebiggers@kernel.org>, David Sterba <dsterba@suse.cz>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>,
Josef Bacik <josef@toxicpanda.com>, "clm@fb.com" <clm@fb.com>,
"dsterba@suse.com" <dsterba@suse.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
qat-linux <qat-linux@intel.com>, "embg@meta.com" <embg@meta.com>,
"Collet, Yann" <cyan@meta.com>,
"Will, Brian" <brian.will@intel.com>,
"Li, Weigang" <weigang.li@intel.com>
Subject: Re: [RFC PATCH 6/6] btrfs: zlib: add support for zlib-deflate through acomp
Date: Tue, 27 May 2025 10:32:00 +0800 [thread overview]
Message-ID: <baafb2ad-e2a2-4d40-9759-109c2cad559c@linux.alibaba.com> (raw)
In-Reply-To: <20250508041914.GA669573@sol>
On 2025/5/8 12:19, Eric Biggers wrote:
...
>
> BTW, I also have to wonder why this patchset is proposing accelerating zlib
> instead of Zstandard. Zstandard is a much more modern algorithm.
I think simply because QAT doesn't support the Zstandard native offload.
At least, for Intel Xeon Sapphire Rapids processors (it seems to have
built-in QAT 4xxx), only LZ4 and deflate-family are natively supported.
I've confirmed that SPR QAT deflate hardware decompresion already surpasses
LZ4 software decompression on our cloud server setup, which is useful since
it greatly improves decompression performance (even compared to software LZ4)
and saves CPU overhead completely.
For Zstandard, currently it seems it [1] just leverages part of the QAT
engine: hardware sequence producer (matchfinder) to boost up Zstandard
match finding And I think the current hardware QAT will have no positive
effect on the Zstandard decompression. Without hardware improvements, it
seems it can be hardly changed.
I think it's true for both 5th Sapphire Rapids processors and 6th Granite
Rapids processors. Correct if I'm wrong here but that is what I got so far.
Thanks,
Gao Xiang
[1] https://github.com/intel/QAT-ZSTD-Plugin
>
> - Eric
>
next prev parent reply other threads:[~2025-05-27 2:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 10:54 [RFC PATCH 0/6] btrfs: offload zlib-deflate to accelerators Giovanni Cabiddu
2024-04-26 10:54 ` [RFC PATCH 1/6] Revert "crypto: testmgr - Remove zlib-deflate" Giovanni Cabiddu
2024-04-26 10:54 ` [RFC PATCH 2/6] Revert "crypto: deflate " Giovanni Cabiddu
2024-04-26 10:54 ` [RFC PATCH 3/6] Revert "crypto: qat " Giovanni Cabiddu
2024-04-26 10:54 ` [RFC PATCH 4/6] Revert "crypto: qat - remove unused macros in qat_comp_alg.c" Giovanni Cabiddu
2024-04-26 10:54 ` [RFC PATCH 5/6] crypto: qat - change compressor settings for QAT GEN4 Giovanni Cabiddu
2024-04-26 10:54 ` [RFC PATCH 6/6] btrfs: zlib: add support for zlib-deflate through acomp Giovanni Cabiddu
2024-04-29 13:56 ` Josef Bacik
2024-04-29 15:21 ` Cabiddu, Giovanni
2024-04-29 15:44 ` David Sterba
2024-05-03 10:04 ` Herbert Xu
2024-04-29 15:41 ` David Sterba
2025-05-06 15:38 ` Cabiddu, Giovanni
2025-05-07 2:23 ` Herbert Xu
2025-05-07 12:17 ` David Sterba
2025-05-08 4:19 ` Eric Biggers
2025-05-12 17:52 ` David Sterba
2025-05-27 2:32 ` Gao Xiang [this message]
2025-05-27 2:45 ` Gao Xiang
2025-05-27 11:17 ` David Sterba
2025-05-27 12:08 ` Gao Xiang
2025-05-07 12:43 ` David Sterba
2025-05-07 13:12 ` Cabiddu, Giovanni
2024-04-29 15:57 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baafb2ad-e2a2-4d40-9759-109c2cad559c@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=brian.will@intel.com \
--cc=clm@fb.com \
--cc=cyan@meta.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=ebiggers@kernel.org \
--cc=embg@meta.com \
--cc=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=weigang.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox